Skip to content
OverviewSolutions
5
Comments
4
Khant Min
@KhantMin200

All comments

  • Khant Min•170
    @KhantMin200Posted over 2 years ago

    Hello Aung! Here is my opinion for you. In section 'advice-text', you used 'min-height: 300px'. That's too far from top and bottom. And fonts are a little bit bigger than I can look😂. But that's OK. And., I have nothing to complain. You have already been perfect. ♥♥ Ohh, sorry for grammar if I had any mistake, you know I'm not good at English😅.

    Marked as helpful
    0
  • stuartambient•50
    @stuartambientSubmitted over 2 years ago

    1- I'd like to know how having the figma or sketch files would help. Would those files provide font-sizes or other values like margins or padding ? I have no experience using either of the software but would consider if it helps making determination more precise then using the provided preview images.

    2- I considered using a HTMLFormElement for this component. Pretty sure in the past I used a hidden check box or radio group for something similar. After some consideration I used ul / li's instead, pretty simple without having to struggle with radio or checkbox styling. It's only one value gong to javascript anyway. Is there a preference or a standard in these situations ?

    Interactive rating component with css and javascript

    3
    Khant Min•170
    @KhantMin200Posted over 2 years ago

    Hello! There is nothing standard situations to get values along my experience. I used ul/li tags too. And in my opinion, you should use submit button bigger.

    1
  • Khant Min•170
    @KhantMin200Posted over 2 years ago

    Nice work! My opinion is you should use CSS property 'cursor: pointer' on 'learn more' button to show that we can click that button.

    Marked as helpful
    0
  • Khant Min•170
    @KhantMin200Posted over 2 years ago

    Using <i> frame is very intelligence. I didn't think it before when I'm doing the same pj. Nice! And I want to suggest you is you should use CSS property 'height: 100vh; // vh --> viewport height' to center main container in every screen. In my laptop screen your pj header is cover by tabs!!! But finally to think over, you did the best bro. 🤍

    Marked as helpful
    1