Skip to content
OverviewSolutions
11
Comments
7
kath
@Kathund

All comments

  • kath•130
    @KathundPosted over 2 years ago

    Looks great as is two things I just want to point out that you never imported the font?

    If you opene up the style-guide.md file that got when you downloaded the collection of files. At the bottom of it section called font. It has links to the two fonts that it wants to you to with the weights.

    How to import When you click the link select the weights that are said in the style-guide.md file. To select click the text that says Select this style Then copy the links that comes up and paste them into ur <head> tag

    0
  • kath•130
    @KathundPosted over 2 years ago

    Says 404 on view. This happeneds when the website is still being uploaded. Next time I would wait maybe 5 or 10 minutes for it to upload. Please resubmit it and I will come back and check it

    0
  • kath•130
    @KathundPosted over 2 years ago

    Looks good but was looking at your report and found something that might help.

    One of your "Accessibility Issues" The text said <a href="/" class="logo logo-img-1x"> To fix this you can remove the / in your href and replace it with a #

    This works because when checking the url it will come back fine because # means id and you can jump to a id by calling it in your url. if I had an id called test. I can jump to it by going to mywebsite.com/#test

    Hope this helps

    0
  • kath•130
    @KathundPosted over 2 years ago

    Looks Amazing Keep up the work!

    0
  • taylor•10
    @taylesperSubmitted over 2 years ago

    My second attempt after receiving some feedback. I feel pretty comfortable with grid but I think I am missing a couple of pieces to make it responsive. Any feedback is appreciated! Also, if anyone has tips on how to refactor my CSS to be as simplified as possible, that would be great.

    QR Code Project

    1
    kath•130
    @KathundPosted over 2 years ago

    code looks fine but your github build failed

    0
  • kath•130
    @KathundPosted over 2 years ago

    Congrats after 4 attempts you have managed to get it working! After looking at your code the only thing that i would say is that it can be better to put all your styles code in a css file. Basicly coppying all the stuff in a Style tag i would put it in a css file then link to it with <link rel="stylesheet" href="style.css"> then put that just above your title in the html file. Most People would use a css file because people find it easier and better to have it in a css file. BUT remember this is your choice

    0
  • kath•130
    @KathundPosted over 2 years ago

    since your code is in a zip github cant use it and wont produce the website. please resubmit when unziped and can see the final project live in the website

    Marked as helpful
    0