Skip to content
OverviewSolutions
27
Comments
10
Just9krish
@Just9krish

All comments

  • Just9krish•590
    @Just9krishPosted over 2 years ago

    Color of cross price should be gray not black.

    1
  • Just9krish•590
    @Just9krishPosted over 2 years ago

    Hey sachin congratulation for completing this project and your solution is responsive and i like that. Coming to question i would encourage you to learn grid in css. For this challenge i think Grid Area would be great and it'll reduce number of lines of code.

    0
  • Just9krish•590
    @Just9krishPosted over 2 years ago

    First congratulation for completion of this challenge.

    To avoid Accessibility Issues, use at least on Heading tag in your code. and try to add box shadow to the card , cuz it is does't look good.

    Have fun that's all was mine advise.

    Marked as helpful
    0
  • Just9krish•590
    @Just9krishPosted over 2 years ago

    First congratulations for completing this challenge.

    As you asked for improvement of responsiveness so my recommendations for you should use mobile first approach, where you design for mobile first then for other display size. This will improve lot and use more flexbox and grid this will reduce the media queries and make things simple.

    And the problem i see in your solution is that your btn and other content stretched completely to the edge of mobile screen and that things generally people don't like it. There should be some margin. And use more spacing or padding or margin, cuz content are like they are glue to each other in my opinion.

    But good with solutions keep griding.

    0
  • Felipe•40
    @FelipeBMostSubmitted over 2 years ago

    My third project. I can't seem to grasp how to adjust elements vertically on flexbox. I set up the ".row" and "display flex" on parent together with "align-items" and "justify-content" everywhere and the "Change" element stil wouldn't center. I had to adjust it's margin to make it centered.

    Order Summary with HTML and CSS Flexbox

    2
    Just9krish•590
    @Just9krishPosted over 2 years ago

    Bro first push your code to git hub i can't see your code

    1
  • Just9krish•590
    @Just9krishPosted over 2 years ago

    As i can see you are new to this stuff, so i recommend you to learn responsive website from Free Code Camp. And after completing their project you will get certificate too.

    Marked as helpful
    0
  • Just9krish•590
    @Just9krishPosted over 2 years ago

    Learn the blend mode in css to overlay image. otherwise as beginner you are good, so keep learning, keep practicing. and for headache take break :)

    Marked as helpful
    1
  • Just9krish•590
    @Just9krishPosted over 2 years ago

    Any feedback is appreciated!

    0
  • Carl Lindberg•20
    @carlzxc71Submitted over 2 years ago

    Hello,

    This is my second attempt at this, here is my first one: https://www.frontendmentor.io/solutions/3columnpreviewcard-challege-html-and-css-tcguJpo1m

    I used position: absolute/relative; and moved items with left & right etc. I was informed this is a bad habit and was told to look at FLEXBOX.

    I did and re-created this challenge this time with FLEXBOX. This is my first time using this and I only recently started a web dev course so I am still new to html, css & flexbox. I am looking for some feedback:

    • How could I have improved my code and made it easier? Maybe parts of my code is redundant?

    • If I resize my screen the paragraphs go outside the color-boxes, is there a way to prohibit this?

    Any other feedback is much appreciated.

    Thank you very much in advance!

    3-column-preview-card-component using FLEXBOX

    1
    Just9krish•590
    @Just9krishPosted over 2 years ago

    You have made lots of mistake, like sedan svg is not showing in output use "./" in img src to locate path of file, first clear concept of flex box and basic of css. for this read blog and watch youtube video and keep practicing as you are new in this so keep practicing and keep learning.

    0
  • Just9krish•590
    @Just9krishPosted almost 3 years ago

    Learn and use mix blend mode to color image.

    Marked as helpful
    0