Skip to content
OverviewSolutions
13
Comments
9
Julian Köhler
@JulianKoehler

All comments

  • Julian Köhler•430
    @JulianKoehlerPosted over 1 year ago

    I like that you are reducing the categories from the data! This exactly is following the open-closed principle. However I would have liked if you included for instance a firebase database for storing the order, maybe generating an order confirmation number which is sent back to the customer :)

    Marked as helpful
    1
  • Julian Köhler•430
    @JulianKoehlerPosted almost 2 years ago

    I really like your eye for details in design. It feels very smooth and you really translated the design well. I also like your firebase solution. But your filter function is a bit weird. Instead of forcing the user to search for the exact job title, consider filtering the job listings with either .contains() or .startsWith() and consider adding tags to the job objects like experience wanted and technologies needed. And don't forget to make everyting .toLowerCase() in the function. That way I think you can inmporve the filter function.

    0
  • Ken•4,915
    @kens-visualsSubmitted about 2 years ago

    This was a great project to practice working with time, user inputs and multiple themes. I chose to use React context for state management, because it's not a massive app and I didn't want to over-engineer it with redux or any other state management system. As I already mentioned in one of my previous projects, Tailwind makes it really easy to build multi-theme websites, and in general it simplifies styling of the page. The more I use TypeScript the more I understand how it's getting more popular day-by-day. As always, I wanted to add my personal touch to the project, so I added some sound effects to enhance the interactivity of the app. Also, this will actually help to know when the time's up (I won't spoil anything anymore, go experience it yourself). I also didn't change dials for number inputs and left it as browser defaults. Why? Because of inconsistency of the browsers, some browser won't even hide the default dials, so it becomes very annoying to interact with the app when there are 2 types of dials. Other than that, I loved this project a lot, hope you will too.

    Feel free to leave feedback or suggestion in the comments' section 👨🏻‍💻 Cheers 👾

    Pomodoro PWA built w/ Next.JS, TypeScript, Tailwind, and Framer Motion

    1
    Julian Köhler•430
    @JulianKoehlerPosted almost 2 years ago

    Wow this one is insane! I am really hyped about your animations and sound effects, did you use react-reveal for that? Did you manage to play an audio once the timer is expired on mobile browsers? Unfortunately I already heard that mobile browsers only support audio on user events so the soundeffect when the timer ran out won't play. Would you mind having a look around my code on this project? You seem to have experience.

    0
  • Chris Nowicki•140
    @chris-nowickiSubmitted almost 2 years ago

    This is my first time writing a project in TypeScript and SCSS. I definitely had to do some research on TypeScript for React including seeing how others might have used TypeScript with this project... I LEARNED SO MUCH!

    With SCSS ... I am loving writing my CSS this way with nesting and mixins for the media queries.

    One thing that bugs me is the Input buttons on the Time Settings. On Safari (in MacOS/iPhone) they show up different. I need to look into fixing this.

    Any feedback/comments appreciated! It's how we learn, right? :)

    Pomodoro App using Vite, React, SCSS, and custom React Hooks.

    1
    Julian Köhler•430
    @JulianKoehlerPosted almost 2 years ago

    Hey, great job, this project wasn't easy. But I have found 2 bugs with which I also struggled: I am able to enter negative timers and if applied the app crashed completely and I am only able to use it again if I clear my localStorage from the console. I guess an average user would not be capable of that. And the second thing is that I can change the phase while the timer is running. I have implemented a Modal asking the user if he really wants to skip this phase and then resetting the timer and clearing the Interval. Check out my solution if you like to.

    Marked as helpful
    0
  • Julian Köhler•430
    @JulianKoehlerPosted almost 2 years ago

    Great! I could almost guess you have watched the Web Dev Course from Angela Yu on Udemy? :D I did as well and she taught EJS in combination with Express, great work.

    1
  • Julian Köhler•430
    @JulianKoehlerPosted almost 2 years ago

    Awesome! I love your animation on the color theme button. But I think you are missing the content property on the job details page, you are only showing the bullet points.

    0
  • Julian Köhler•430
    @JulianKoehlerPosted almost 2 years ago

    I like your "back-to-jobs" button, good job, only the desing is not 100% accurate :)

    0
  • Julian Köhler•430
    @JulianKoehlerPosted about 2 years ago

    Guys I would be very curious about how you handled the second page? Did you linked another html and if yes, how did you keep track of the rating the user selected? I ran into several issues, so I decided to just set the complete innerHTML of the body to the new page :D

    1
  • Julian Köhler•430
    @JulianKoehlerPosted about 2 years ago

    Unfortunately in this solution page you will not see any data from the JSON since I decided to import the JSON data as a module. I assume this web page is not running my code on a local server like I did with VS Code Liveserver when I was developing. Check out my project on Netfliy! There everything works properly.

    0