Skip to content
OverviewSolutions
27
Comments
3
Jorge A. Mendoza II
@JorgeAMendoza

All comments

  • rappeu-dev•80
    @rappeu-devSubmitted over 1 year ago

    I had a few problems with the Character length slider. I'm always unsure with my JS. How to do it better?

    Password Generator App

    1
    Jorge A. Mendoza II•720
    @JorgeAMendozaPosted over 1 year ago

    Hey! Great solution! My recommendation would be to disable the "generate" button when the user does not have any options selected, or to not allow a user to uncheck everything from the options. Since most sites require a password of at least 8 characters, maybe it would best to also set the min password length of your generator to 8!

    Overall great solution!

    Marked as helpful
    0
  • Jorge A. Mendoza II•720
    @JorgeAMendozaPosted over 1 year ago

    Hello! Great attempt, the page is mostly responsive and your solution matches the design.

    Some things I believe that can be improved upon:

    • Starting on screen-width 425px, your mobile menu "hamburger icon" is rendering along with the desktop navigation list, causing an awkward layout. I would look back at your media queries and ensure that elements are hidden away properly.
    • If a user opens up the mobile menu and expands the screen size, the "close-menu" icon appears next to the logo past the screen width of 425px. I would recommend implementing an event listener for window resizes that ensures to properly remove/hide the mobile nav menu on larger screens.

    Please feel free to checkout my solution to this project for reference!

    Marked as helpful
    1
  • Angelo•190
    @Onecode24Submitted about 3 years ago

    How to ensure that content is always in the center regardless of the device

    Comment faire pour que contenu soit toujours au centre quelque soit l'appareil

    Tip_Calculator Js css html

    1
    Jorge A. Mendoza II•720
    @JorgeAMendozaPosted about 3 years ago

    Good afternoon, I would recommend using flexbox to quickly center something. For example, in desktop mode, have your body act as the flex container with a flex direction of column, then set the justify and align properties to center.

    If that doesn't answer the question please check out stack overflow!

    Marked as helpful
    0