@michaelleopoldSubmitted over 4 years ago
Still so much to learn and fix. Any advice would be great.
Jonathan Martínez
@JommartinezAll comments
- @JommartinezPosted over 4 years ago
There is nothing wrong, the only thing, remember that the IDs must be unique and you are repeating them
3 - @nleftySubmitted over 4 years ago
I could use some feedback on the sizing of the desktop image. I'd like the image height to be that of the viewport. Thanks
@JommartinezPosted over 4 years agoYou can use one container 50% width, height 100%. Also image width and heigth 100% with object-fit: cover
2 - @Scoro6Submitted over 4 years ago
Hey It is my first challenge It is not perfect but I'll love to hear how can I make this perfect. Thanks.
@JommartinezPosted over 4 years agoTo be your first challenge it is perfect :) keep it up and you will see that great projects you can develop very soon
6 - @f-m-a-lySubmitted over 4 years ago
Feedback appreciated! Thanks!
@JommartinezPosted over 4 years agoit's not bad at all. maybe I would correct the accessibility notices to go perfectly :)
6 - @kcdeSubmitted over 4 years ago
Are there better ways to do it?
@JommartinezPosted over 4 years agoHello :) It is very well developed. In the end there are no better or worse solutions. Each developer has a different point of view.
maybe the hamburger on the menu would put it as a <span> so that you don't get the accessibility error, otherwise everything is ok
5 - @sharmaeklavyaSubmitted over 4 years ago
I would really appreciate if you could spare few mins of yours and provide a feedback.
Thank you so much.
@JommartinezPosted over 4 years agoIts fine, but for the white box you can use the pseudoelement ::after for example: ::after { content: ""; position: absolute; top: 69px; right: 0; border-top: 25px solid #ffffff; border-left: 25px solid transparent; } (or similar for your solution)
Marked as helpful5 - @MaujorSubmitted over 4 years ago
Feedback are wellcome
@JommartinezPosted over 4 years agoIt is fine, but I have seen a problem ... If you want to do a search from the input search, it does not work with the keyboard enter. you need to click on the icon. I think it is highly recommended to enable keyboard use :)
5 - @GTrialonisSubmitted over 4 years ago
It took me a very long time to complete to the stage it is now. Some CSS code may not be necessary. Mobile active state not as recommended but working anyway. This is my second web site.
@JommartinezPosted over 4 years agoOh! To be your second challenge it is very well developed .. Keep it up and with practice it will be very easy to do advanced challenges :)
6 - @arun-robertsSubmitted over 4 years ago
First time using BEM. How did I go applying the structured naming? It was a little getting used to but in the end I really enjoyed the order it brought to my thought process. Not to mention the potential for reusability.
I can see that it might be a little overboard for a project of this size and smaller. Is this how others feel or is it applicable to pages of any size?
@JommartinezPosted over 4 years agoFrom my point of view, BEM is a very good methodology for large projects or small projects that are going to scale over time ... But for small projects, I don't really see it as necessary.
5 - @rohailtahaSubmitted over 4 years ago
How can I make the bottom right corner of the white pop up (one that says "185 GB left") appear triangular?
@JommartinezPosted over 4 years agoYou can use the pseudoelement ::after for example: ::after { content: ""; position: absolute; top: 69px; right: 0; border-top: 25px solid #ffffff; border-left: 25px solid transparent; } (or similar for your solution)
6
