@Harshl-KhondSubmitted 3 months ago
JokerSent31
@JokerSent31All comments
- @Rpr9110Submitted 3 months ago@JokerSent31Posted 3 months ago
solution include semantic HTML Is it accessible Cool that you're using root: . I'll take a note Is the code well-structured, readable, and reusable
1 - @feyzanrsnrSubmitted 3 months ago@JokerSent31Posted 3 months ago
Solution include semantic HTML Is it accessible The layout doesn't look good on different screen sizes (width < 420px - looks bad). The code well-structured, readable, and reusable The solution doesn't differ considerably from the design
0 - @vidyaa01Submitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud that I finally deployed the website.
- Either the paths were wrong or built it with jekyll.
- But finally for 3rd or 4th time it was deployed.
Next time I would like to encounter problems more patiently and would research about them to solve them.
What challenges did you encounter, and how did you overcome them?- When I deployed for first time, images were not displaying.
- I accidently made it with jekyll.
- To overcome this challenge , I created the whole repository again and worked on it from scratch.
2 . Even after verifying all the paths the site was still not displaying.
- This was because I wrote the whole code in a new folder , rather than placing it as it is in main.
- After shifting it to main, the page was deployed.
Is there any way to deploy with github pages from a folder which has index.html within it?
@JokerSent31Posted 3 months ago- Yes, the solution include semantic html. But use "main" tags.
- You should be use styles in .css file. And you should be use BEM methodology for naming classes.
- You can make width card block stretch and set max-width: 320px.
- Is the code well-structured, readable
- Look like to design by 70%
Marked as helpful0