When trying to style and , I learned that it sets the display to list-style. I was using Flexbox on it, and the bullets of the list would disappear, so it took me a bit to figure out why.
I liked the solution you gave to the bullet points in unordered lists. I did it in a different way, but your solution is definitely better than mine, so I'm stealing it from you.
I would only suggest that you use the Figma file so that your dimensions closely match those in the design.
Hi Mohamed, I hope you're doing well. Here, I will leave some suggestions in the hope you find them helpful.
div class="links" you could have used a <nav></nav> tag, which would make your code more accessible to people with disabilities. You could have also added a <main></main> tag or a <section></section> tag so that your page gets better SEO.I am proud that I was able to pick an area to focus on improvement and make progress in that area. In this project, I focused on being more organized with my CSS, and I think I accomplished this by using Kevin Powell's convention for organizing CSS properties, as well as using BEM to name elements' classes.
What specific areas of your project would you like help with?I would like to know if there are other things I should consider when it comes to organizing my CSS or just improving my CSS in general. I know that this smaller project doesn't necessarily require as much organization, but I wanted to aim for organization as if this were a much larger project.
Hi Nathan, I hope you are doing well. I will briefly describe some things that you can consider for future projects:
card__footer you could have actually used a footer tag there, so that you improve the accessibility of your page.@media so that you could add those different values.I think your coding was excellent, and you definitely succeeded at implementing the BEM model. I'm clearly taking that away from you.
dalam pembuatan website, saya membuat dulu sebuah container yang saya buat pembungkusnya body, dengan lebar dan tinggi vw,vh agara relatif dengan lebar layar kita, didalamnya ada 2 kolom , kiri dan kanan , saya berikan juga padding , di bagian kanan / frame saya berikan margin auto , begitu juga dengan rectangel , karena pembungkusnya flex, didalamnya bisa / itemnya bisa kita kasih margin: auto; biar pas ditengah
Hi, @Sofyan, I hope you are doing fine. Your design is full of creativity, but I think the goal was to reproduce the provided design as it appears, with no explanatory text.
This is a simple project but it my first non-tutorial project since learning to code so I am proud of simply being able to complete it on my own.
What challenges did you encounter, and how did you overcome them?The main difficulties that I encountered were learning to get the appropriate information from the Figma file and getting the page to display properly on GitHub Pages (it was a file path issue).
What specific areas of your project would you like help with?Have I completed this challenge as intended? The design file in figma does not show any additional background but the "preview" file shows an additional background applied behind the grey box background.
Click on the link I sent and it'll give you an idea of what you have to do. Do not worry about them saying there are mobile or desktop versions. When you do the desktop version, mobiles will accommodate the content automatically.
This is a simple project but it my first non-tutorial project since learning to code so I am proud of simply being able to complete it on my own.
What challenges did you encounter, and how did you overcome them?The main difficulties that I encountered were learning to get the appropriate information from the Figma file and getting the page to display properly on GitHub Pages (it was a file path issue).
What specific areas of your project would you like help with?Have I completed this challenge as intended? The design file in figma does not show any additional background but the "preview" file shows an additional background applied behind the grey box background.
Hi @rtoddm. I think that you misunderstood the aim of the challenge. You shouldn't have replicated the screenshot. On the other hand, you should have created the page for desktop, and it would automatically adjust for mobiles.
My challenge isn't perfect and I have a lot of suggestions from our colleagues that I have to implement. I will share my URL so that you can see what it was all about. Click here for the QR code challenge
Cheers,
Johann.
