@omarnate1Submitted 4 months ago
What are you most proud of, and what would you do differently next time?
nothing.
What challenges did you encounter, and how did you overcome them?nothing new
JeyB88
@JeyB88All comments
- @omarnate1Submitted 4 months agoWhat are you most proud of, and what would you do differently next time?
I am proud of my tailwind CSS improvement
What challenges did you encounter, and how did you overcome them?none
What specific areas of your project would you like help with?none
@JeyB88Posted 4 months agogreat job! some recommendations:
- From semantic perspective it would be better to use an unordered list with list items and anchors instead of using buttons. Buttons are normally used to perform a non-navigation action, such as performing a form submit or changing some state.
- font stylings are inherited by children, so you can define all font stuff in the parent instead of declaring the related font classes in each button,
Marked as helpful0 - @amrmabdelazeemSubmitted 11 months ago
Tailwind is much more fun than other frameworks.
ps: the screenshot is adjusted to the center but I ran out of monthly screenshots to show it ~
@JeyB88Posted 4 months agogreat job! some recommendations:
- rather than using h1 for the card title I would use h2 or h3, which is on the semantic perspective the right choice I think. Because h1 is normally used for the heading of a entire page and this card is just a component.
1 - @RiccardoColtrinariSubmitted 4 months ago@JeyB88Posted 4 months ago
great job! some small improvements I would made:
- In my opinion h3 or h2 is from the semantic perspective a better choice as h1 for the qr code title
- What if there is content to add to this component? Right now the height is fix to 497px and will hide the new content. I personally only specify the width and use the auto height and let the spacing between the elements do the rest
Marked as helpful1
