All comments

• 

  Norberto Andres Luna•140

  @GrathienbetoSubmitted about 1 year ago

  Difficulties about this project.

  I've been away from CSS for a long time, so remembering a lot properties was a challenge.

  God bless mozilla dev

  Which areas of your code are you unsure of?

  I'm not unsure, but more of "This could easily be better organized" about my HTML tags and my CSS. Im pretty sure i repeated myself a lot. It could use a refactor, but considering is a small project i think i can move on.

  Do you have any questions about best practices?

  Yes, a lot.

  • Span vs paragraphs / headers in small sentences or just one word.
  • Best ways to aproach CSS
  • Name conventions

  This three just for a fast start.

  

  Summary Result Challenge

  3

  61
  

  JesnerW•210

  @JesnerWPosted about 1 year ago

  I recommend you to separate the css variables into :root{ --color_white: hsl(221, 100%, 96%); }

  0
• 

  Jason Campbell•10

  @jcampbell18Submitted over 1 year ago

  What did you find difficult while building the project?

  • just re-familiarizing myself with HTML, CSS, and having it responsive

  Which areas of your code are you unsure of?

  as dumb as this sounds, the shorthand for 'font` in CSS

  Do you have any questions about best practices?

  Since this was written in basic HTML and CSS (without frameworks), is there anything more that I could do to tighten down my code? Whether it be refactoring, or sizing or... anything. For example, could I have made it without even using a media query..?

  

  Responsive QR Code Component Solution

  3

  70
  

  JesnerW•210

  @JesnerWPosted over 1 year ago

  Hello there 👋. You did a good job!

  I have some suggestions about your code that might interest you.

  Try to have a better look to have a more accurate solution, the width of the container is about 295px.

  Marked as helpful

  0