Skip to content
OverviewSolutions
7
Comments
2
Jeremy Mendoza
@JeremyMen

All comments

  • Carmen•490
    @CarmenyoSubmitted over 2 years ago
    What are you most proud of, and what would you do differently next time?

    Approaching React through this simple project has allowed me to gain a clearer understanding of what happens under the hood when I implement React.

    What challenges did you encounter, and how did you overcome them?

    The challenge was organizing my files and gaining a clearer understanding of how React works.

    What specific areas of your project would you like help with?

    In this project, I haven't needed help nor had significant doubts

    Product Preview Card Component

    3
    Jeremy Mendoza•100
    @JeremyMenPosted over 2 years ago

    Hey Carmen,

    these are my advices:

    • Try to use more meaningful HTML tags. You could have used <figure> tag which is perfect when you deal with images + some text related to it.
    • about your CSS, I can see many positive things: you have followed BEM methodology, reset the browser's default values and used variables. Cheers for that! Next time I suggest you to use rem/em while setting the size of any element.

    Keep up the good work!

    Jeremy

    Marked as helpful
    0
  • Dbttlnkd•20
    @DbttlnkdSubmitted over 2 years ago

    This is my first design on HTML/CSS for which I had the opportunity to learn about Flexbox.

    I had some difficulties on making sure the cart SVG was fully centered on height and I did not succeed with using a [html <button>] and [css::before].

    I corrected the issue with using [html <a href"">] instead. Not sure if this is the best way.

    Thanks for your feedback.

    Product Preview Card Component using HTML/CSS & Flexbox

    2
    Jeremy Mendoza•100
    @JeremyMenPosted over 2 years ago

    First of all I would like to congratulate you because your solution is very similar to the given design. Cheers for that!

    I would probably have used the <figcaption> tag (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/figure) in order to have a more semantic HTML.

    About css, in my company we follow the BEM methodology (http://getbem.com/introduction/). I wouldn't say that it is mandatory to use it but nowadays you really want to follow some kind of pre-set guidelines in order to have your css clean and scalable.

    Keep up the good work!

    Cheers,

    Jeremy

    0