Jean
@JeanMiesesAll comments
- @lotfy1654Submitted almost 3 years ago@JeanMiesesPosted almost 3 years ago
Hey brother. There are a few things you should fix. The "product-section" should be centered vertically. Add a working "Cart' component as well, so when I click add to cart button, it adds the product to the cart. Also, when I click to add quantity or decrease, the adds to cart button moves. I think it is cuz the padding. I feel that is something you should look into.
I love the design. It is way better than mine. I missed the cart image in the add to cart button as well. And how did you implement the carousel? I used a library for it called Splide cuz coding it on my own would have taken a bit of work and I am too lazy. Your carousel looks amazing.
here is my project https://www.frontendmentor.io/solutions/ecommerceproductredux-dei3tJbWL
0 - @vishalbrdrSubmitted about 3 years ago
Used React for the first time, any feedback will be appreciated.
@JeanMiesesPosted about 3 years agoHey man, it looks great. Just one suggestion. You should organize your file a bit better. You have your .JPG images in the same folder as your CSS and js files. I feel it would be better if you create a folder 'images' or something like that and add all your images there. Great job btw. I will try to do the same soon since I just learning react.
Marked as helpful1 - @annacsillaxsSubmitted over 3 years ago
Hi Everyone!
I've chosen the JS-heavy approach and I'm not sure if I dealt with it correctly. I had some issues where to place the data.json file, but it's working and I'm happy with the result.
Feedbacks are appreciated :)
Have a great one
Anna
@JeanMiesesPosted over 3 years agohey anna, the design is great, but when I click any of the planets on the top, the page does not update to the planet I clicked on. You should definitely look into that. That is the main challenge. Also, if you could push your code to github, we will appreciate it lol.
0 - @yasssuzSubmitted over 3 years ago
HELP!
Guys, everything works fine, except for one thing that I'm trying to fix. If you take a look at the jobs languages and tools, you will see a comma between each item. Why is that happening? How can I fix this?
Happy coding :)
@JeanMiesesPosted over 3 years agoeverything looks good. There is a , between some off these labels.
0 - @otmanezahhariSubmitted over 3 years ago
If anybody would like to review my code and give me feedback that would be great!
Any other type of feedback is appreciated as well! Thank You!
@JeanMiesesPosted over 3 years agoThere is an issue where I can't add comments in any post. The road map and the buttons to filter posts go away when you are on mobile devices. When I open a specific post and try to refresh, I get a 404 error... It is probably a GitHub pages bug. Other than that, it looks amazing.
0 - @Andrii-RohovSubmitted over 3 years ago
Hello everyone, this challenge was a lot of fun) Anyway, if you have any feedback about my solution please leave a comment.
@JeanMiesesPosted over 3 years agoMan, amazing work! The only thing I would suggest you do is to use sections more often instead of divs. But this is great!
Marked as helpful0 - @ScottGrunSubmitted over 3 years ago
Hey everyone would love some feedback on items listed below if you have a minute or if you feel I could improve in any other area listed below please let me know ! :D
-
How is my file structure (is it clean, does it make sense)?
-
How did I do in composing my pages and components, (should things be broken down more, are the components themselves generic enough)?
-
My biggest issue I feel is managing data/state in the app, would really appreciate it if anyone has any better ideas could maybe point out places where I could use context more and prop drill less.
@JeanMiesesPosted over 3 years agoMan, I love the 3D effect when you click the surface of the planet. I read a bit of your code and even for a amateur like me, I was able to understand what each component does. The only thing I would change is the planet size for desktop. I feel it is a bit small... How did you get that 3D effect? Lol I wish I would have used something like that on my project.
Marked as helpful1 -
- @mewebbieSubmitted over 3 years ago
I feel I kinda accomplished the task, but maybe I need to work on writing clean code? This is the first time I've accomplished something this complex(atleast to me), would love to hear feedback on how can I improve.
@JeanMiesesPosted over 3 years agoGreat job Bro. I took a quick look at your code. It looks pretty clean. My only suggestion is don't use var when creating a variable. Instead, use let or const.
0 - @mohamed7799Submitted over 3 years ago
i would like to hear your feedback about how my scss code is written and on how is my design is close to the original one, thanks.
@JeanMiesesPosted over 3 years agoHey, great work. The only thing I would do is add a bit of margin between the "Full access for less than $1 a day" and the signup button.
Marked as helpful1 - @charlottesaidiSubmitted over 3 years ago
Tried a live clock, don't hesitate to tell if it's buggy or if the time doesn't match where you are (I got the French time here, which is right of course but there's no "zero risk"...). Thank you ;)
@JeanMiesesPosted over 3 years agoHey on my desktop, the background is not covering the entire page. It is about 50% width and height as well. Here is an image https://ibb.co/vDKdLmH
It looks fine on mobile.
Marked as helpful1 - @seanred360Submitted over 3 years ago
I am wondering how close clients typically expect the final product to match to layout. I spent too much time trying to get the dimensions to match exactly, and sacrificed some responsiveness for it.
@JeanMiesesPosted over 3 years agoMan, I am working on the same project and I love what you did here. I also took a quick look at your code, and I am so jealous lol. Way better than mine. I hope to be as good as you someday. The only thing I would try to change from your code is to move the planet array to a separate file and then require it to main.js. BTW, I will try to use anime.js as well on my project.
0 - @JeanMiesesSubmitted over 3 years ago
I feel this one of my best projects yet. I did not run into that many problems and my CSS skills have been improving a lot since I started working on more projects. It is about 93% complete, but I wanted to move on to another project. I will probably come back to this and finished it, but I am happy with the result. Any feedback, I will appreciate it!
@JeanMiesesPosted over 3 years agoI realized I missed the symbol on the top of the page, lol oh well.
0