@taimoorattiqueSubmitted about 2 years ago
Hello Guys! Please let me know the mistakes I made or it can be improved or can be done in a better way. Thanks
Jason S
@JasonSa19All comments
- @JasonSa19Posted about 2 years ago
Hey @taimoorattique
I really like your try on the challenge. The styling file is tidy and clean.
2 little points that you could improve on your project:
1: Always try to implement alt-tags in your image-tags. These is important for the accessibility of your project.
2: In the design of the project, the component is also centered vertically. You could do the same with for example flex-box or css grid.
See ya and happy coding :)
Marked as helpful0 - @correlucasSubmitted over 2 years ago
👾 Hello, Frontend Mentor coding community. This is my solution for the QR Code Component.
Making this challenge again was something really amazing for me, first because going back through my past challenges I was able to fix some issues and clean my code and then because was my first time using JS (yes I'm a newbie) 😂
I added some features:
- 🎨 Dark and Light mode button
- 👾 Custom QR Code image
- 🧚♂️ A little bit of color customization
- 👨💻 Custom image hover state
I'll be happy to hear any feedback and advice!
@JasonSa19Posted about 2 years agoI really like the approach as the dark mode is a important part of webdesign and digital design in general at the moment. Keep it rocking!
1
