Sebastian• 1,560
@dnksebastian
Submitted
MaryF
@Janselin
All comments
- MaryF• 350
@Janselin
Posted
Great job!! I've just uploaded my solution for this one but i was wondering how to add the message under the input? when the email is a invalid one. Any tips? thanks
1 - bunee• 2,020
@buneeIsSlo
Submitted
Hi again! The goal for this challenge was to try something new. I had always wondered how custom cursors were made on most of the "modern" webpages you see these days. So this challenge was a perfect excuse for me to learn about them.
Features
- Added a custom cursor.
- The custom cursor expands and acts as an
outlinewhen clicked on the input.
Questions
- How well does this work on your device?
- Did you find any bugs?
Known bugs
-The cursor's movement tends to become awkward upon resizing the window. (Clicking on the document should fix this issue, most of the times)
Click here to view the Live Site
P.S. If you have any questions for me, Feel free to comment or message me on slack :)
MaryF• 350@Janselin
Posted
amazing cursor effect I loved it! The issue I'`ve found on my pc is that i cant access the imput since there's no scroll bar, have you hide it with overflow:hidden? I cant scroll down 😅
anyway I loved this one! Happy coding 🤗
Marked as helpful
1 - Anna• 130
@Anq92
Submitted
What is your way to organise CSS code and what would you recommend me to change in my style.css file? Do you think the way I used div tags and flexbox properties is optimal for this challenge or is there a better way to do it?
MaryF• 350@Janselin
Posted
Hey there! Congrats on your solution! you did great job! I think you did very well with the use of
<div>. Here some tips!🔹I would recommend you to use a
<article>tag for thediv class="box"🔹 you could replace
<div class="container">for a<main >tag.🔹
<p class="main-text">should be a<h1>Just for a better html structure.
Happy coding 🤗
Marked as helpful
0 - Daniel Hernandez• 60
@jhernar
Submitted
all improvements are welcome! I've had some problems centering the container with flexbox, could someone help me with that?
MaryF• 350@Janselin
Posted
Good job on this challenge! Here some recommendations!:
🔹For SEO and html structure, you have to use the headings in order (h1 first, then h2,h3 and so on). Don't use more (or less) than one H1 per page. Make sure the H1 is the first and largest text on a page.
🔹In your case, i would change your
<div class="card card-1>h2for ah1and then useh2,h3.🔹Also in
<div class="card card-3">you can add anullist instad of using<p>:)
Happy coding! 🤗
Marked as helpful
1 - PriankaCodes• 10
@PriankaCodes
Submitted
Hi Team, A newbie coder over here. I have submitted my first solution (woohoo!) I would like to know best practises for coding. Perhaps maybe two or three tips as I am sure there are plenty. My question is should I treat every project the same way regardless of small vs large project (single page vs multiple pages)? ie have my project set up consistently? On this project, I noticed the styles were included in the index.html page so I continued to add my css there. Should I have created a separate styles.css file? Thanks team!
MaryF• 350@Janselin
Posted
Hello and congrats on your first challenge!🥰 First of all,answering your questions. It's always recommended (in general,not only for frontendmentor) to make a separate .css file and not use
I recommend to treat every project (big or small) as the same way so you have consistency on your work. You made good job after all in this web, I suggest you to check the
background-imagesince it looks like you forgot about it 😂🤗Marked as helpful
0 - James• 390
@neenreva
Submitted
Still feels hacky on the responsive design. Any
MaryF• 350@Janselin
Posted
Very good job here! What I noticed was that on laptop size, the buttons are slimmer. You chould check that to fix and get some pixel perfect ;) Also
main section pyou can make the font-weight thinner.Happy coding! 🤗
0 - Florence Martin• 30
@Florence-Martin
Submitted
MaryF• 350@Janselin
Posted
Great job here!
Just one advice. For html semantic reasons, you should start your website/project with h1 and then h2,h3 and so on. On this case I'd change your
h2inclass="card-body"for ah1. Also if you want to make it pixel perfect, i would change itsfont-sizefor a smaller one.Happy coding!🥰
Marked as helpful
0 - Felix Criollo• 575
@FelixCriollo
Submitted
- Yes, it took me a while to add the effect to the NFT image.
- Any advice to improve is welcome :3
MaryF• 350@Janselin
Posted
Nice work! you could check again some of the img size + its
hover. Also adding somepaddingon theclass="nft__num"Happy coding! 🤩
Marked as helpful
1 - Adrian Conway• 100
@Adrozipp
Submitted
MaryF• 350@Janselin
Posted
Really nice work! I recommned you to add
overflow: hiddento the class="mobile-container" and class="blacklist" :)0 - Marlon Monsores• 60
@monsor3s
Submitted
#react #styledcomponents
MaryF• 350@Janselin
Posted
nice work! but i will suggest you to check again the header logo and the main img and the register button. When i opened it on my pc ,the header logo and button are behind the img.
1 - SB• 65
@sbapollocoder
Submitted
I started again so this is a v2, feel free to give me any feedback, not matter if you're newbie like me or expert!
I have put in more responsive design. I started with the mobile design first. I struggled with the responsive stuff but it was good to learn some things about it
I broke the media query at 1024px so that the ipad pro screen would still display the mobile version as that seemed more appropriate.
MaryF• 350@Janselin
Posted
Great work! I like how you managed the img and the color overlay! Also the stats with the ul tag! smart!
Marked as helpful
1
