@dnksebastianSubmitted over 2 years ago
MaryF
@JanselinAll comments
- @JanselinPosted over 2 years ago
Great job!! I've just uploaded my solution for this one but i was wondering how to add the message under the input? when the email is a invalid one. Any tips? thanks
1 - @buneeIsSloSubmitted almost 3 years ago
Hi again! The goal for this challenge was to try something new. I had always wondered how custom cursors were made on most of the "modern" webpages you see these days. So this challenge was a perfect excuse for me to learn about them.
Features
- Added a custom cursor.
- The custom cursor expands and acts as an
outlinewhen clicked on the input.
Questions
- How well does this work on your device?
- Did you find any bugs?
Known bugs
-The cursor's movement tends to become awkward upon resizing the window. (Clicking on the document should fix this issue, most of the times)
Click here to view the Live Site
P.S. If you have any questions for me, Feel free to comment or message me on slack :)
@JanselinPosted almost 3 years agoamazing cursor effect I loved it! The issue I'`ve found on my pc is that i cant access the imput since there's no scroll bar, have you hide it with overflow:hidden? I cant scroll down 😅
anyway I loved this one! Happy coding 🤗
Marked as helpful1 - @Anq92Submitted almost 3 years ago
What is your way to organise CSS code and what would you recommend me to change in my style.css file? Do you think the way I used div tags and flexbox properties is optimal for this challenge or is there a better way to do it?
@JanselinPosted almost 3 years agoHey there! Congrats on your solution! you did great job! I think you did very well with the use of
<div>. Here some tips!🔹I would recommend you to use a
<article>tag for thediv class="box"🔹 you could replace
<div class="container">for a<main >tag.🔹
<p class="main-text">should be a<h1>Just for a better html structure.
Happy coding 🤗
Marked as helpful0 - @jhernarSubmitted almost 3 years ago
all improvements are welcome! I've had some problems centering the container with flexbox, could someone help me with that?
@JanselinPosted almost 3 years agoGood job on this challenge! Here some recommendations!:
🔹For SEO and html structure, you have to use the headings in order (h1 first, then h2,h3 and so on). Don't use more (or less) than one H1 per page. Make sure the H1 is the first and largest text on a page.
🔹In your case, i would change your
<div class="card card-1>h2for ah1and then useh2,h3.🔹Also in
<div class="card card-3">you can add anullist instad of using<p>:)
Happy coding! 🤗
Marked as helpful1 - @PriankaCodesSubmitted almost 3 years ago
Hi Team, A newbie coder over here. I have submitted my first solution (woohoo!) I would like to know best practises for coding. Perhaps maybe two or three tips as I am sure there are plenty. My question is should I treat every project the same way regardless of small vs large project (single page vs multiple pages)? ie have my project set up consistently? On this project, I noticed the styles were included in the index.html page so I continued to add my css there. Should I have created a separate styles.css file? Thanks team!
@JanselinPosted almost 3 years agoHello and congrats on your first challenge!🥰 First of all,answering your questions. It's always recommended (in general,not only for frontendmentor) to make a separate .css file and not use
I recommend to treat every project (big or small) as the same way so you have consistency on your work. You made good job after all in this web, I suggest you to check the
background-imagesince it looks like you forgot about it 😂🤗Marked as helpful0 - @neenrevaSubmitted almost 3 years ago
Still feels hacky on the responsive design. Any
@JanselinPosted almost 3 years agoVery good job here! What I noticed was that on laptop size, the buttons are slimmer. You chould check that to fix and get some pixel perfect ;) Also
main section pyou can make the font-weight thinner.Happy coding! 🤗
0 - @Florence-MartinSubmitted almost 3 years ago@JanselinPosted almost 3 years ago
Great job here!
Just one advice. For html semantic reasons, you should start your website/project with h1 and then h2,h3 and so on. On this case I'd change your
h2inclass="card-body"for ah1. Also if you want to make it pixel perfect, i would change itsfont-sizefor a smaller one.Happy coding!🥰
Marked as helpful0 - @FelixCriolloSubmitted almost 3 years ago
- Yes, it took me a while to add the effect to the NFT image.
- Any advice to improve is welcome :3
@JanselinPosted almost 3 years agoNice work! you could check again some of the img size + its
hover. Also adding somepaddingon theclass="nft__num"Happy coding! 🤩
Marked as helpful1 - @AdrozippSubmitted almost 3 years ago@JanselinPosted almost 3 years ago
Really nice work! I recommned you to add
overflow: hiddento the class="mobile-container" and class="blacklist" :)0 - @monsor3sSubmitted almost 3 years ago
#react #styledcomponents
@JanselinPosted almost 3 years agonice work! but i will suggest you to check again the header logo and the main img and the register button. When i opened it on my pc ,the header logo and button are behind the img.
1 - @sbapollocoderSubmitted over 3 years ago
I started again so this is a v2, feel free to give me any feedback, not matter if you're newbie like me or expert!
I have put in more responsive design. I started with the mobile design first. I struggled with the responsive stuff but it was good to learn some things about it
I broke the media query at 1024px so that the ipad pro screen would still display the mobile version as that seemed more appropriate.
@JanselinPosted over 3 years agoGreat work! I like how you managed the img and the color overlay! Also the stats with the ul tag! smart!
Marked as helpful1 - @Ranzor234Submitted over 3 years ago
Please add some advoce or correction peace :)
@JanselinPosted over 3 years agoGreat work! It would be nice if you add some
<a> </a>on the "learn more"Marked as helpful0
