@JYLN
@vanshraheja75
Submitted
What are you most proud of, and what would you do differently next time?
it was an easy one
What challenges did you encounter, and how did you overcome them?
no challenges
What specific areas of your project would you like help with?
any suggestion acceppted
@JYLN
Posted
I like your use of min-height and flexbox for centering content. It was a trick I learned way too late into my learning, and it's been a life-saver with centering content. I also have used grid with the same min-height technique and it's great!
The only suggestions I have is:
min-height. It's a habit I have as well. Ultimately, I think it's best that the flow of the layout justifies the heights of the overlying elements.Overall, great job! Keep up the good work
Marked as helpful
@MesrouaDjamel
Submitted
@JYLN
Posted
Great work on your solution! Even though this is a simple project, I think it's great practice for using and understanding Next, so I commend you there.
A few things I noticed while looking through your code that could potentially use some improvement:
Learning tag and published date could be a little smaller. The Figma design file provided with this project gives some great insight on what that spacing and sizes could look like.Overall, keep up the good work!
Marked as helpful
@MattPahuta
Submitted
What are you most proud of, and what would you do differently next time?
A straightforward component that required minimal markup and styles. I've enjoyed working on these smaller projects to focus on fundamentals and be reminded that there's value in keeping solutions simple and easy to understand.
What challenges did you encounter, and how did you overcome them?
Even with this simple component I initially added more markup than was necessary. It felt good tearing things down to the studs.
@JYLN
Posted
I think your solution is great! I completely understand your statement regarding overcomplicating the markup (I do it a lot too), it's fairly easy to do but good on you for reviewing and refactoring upon that.
I also like the simplicity of how your CSS file is laid out with the variables, reset, and base styles. I especially enjoy the comments of your variables containing the sizes of your intrinsic units in pixels. It shows you paid close attention to detail regarding the design spec.
Great work!
Marked as helpful
@front-end786
Submitted
It was a amazing project for me. I've learned many thing from this project. Thank you so much for this beautiful project. I was had a problem of this project. The problem image which you have use for body background. There is no available in your folder. Thank you much Sayyed Asad Ullah
@JYLN
Posted
Great work on your solution!
I'm unable to review your exact code as it appears the GitHub link is broken, but based on the code I'm seeing through inspect, the code looks great!
One thing I did notice, which I'm not sure if it's a build issue (if you used React based on the tags of the your solution), but there appears to be a <br> within the title (<h3>) of the QR code card text. Ultimately, I believe you'd want to have this as one line of text and leverage CSS for the correct breaking of words. One easy way I can see this implemented in your code is by adding padding on the left and right side of your <div> element containing the text. According to inspect, it appears there's only bottom padding.
Overall, great work!
