I thoroughly enjoyed every moment of working on this project! Applying the CSS flex display property effectively was great. I’m always eager to improve, so if you have any suggestions, I’d love to hear them!
JJorgeMS13
@JJorgeMS13All comments
- @Dev-mustySubmitted 2 months agoWhat are you most proud of, and what would you do differently next time?@JJorgeMS13Posted about 1 month ago
Hola me gusto mucho como implementaste tu proyecto, tengo algunas sugerias que podrian ayudarte a mejorar e seguido las rutas de aprendizaje aqui en Frontend Mentor y te dan algunas pautas como utilizar rem en vez de px exite una practica para facilitar la conversion de rem a px lo que yo hago es poner. html { font-size: 62.5%; } y un ejemplo que quieras ponerle 16px de font size a un parrafo lo puedes poner asi: p { font-size: 1.6rem; } si te das cuenta 1 rem equivale a 10 px y eso hace muy facil la conversion, saludos espero que te ayude.
Marked as helpful0 - @aouintihouariSubmitted about 2 months ago@JJorgeMS13Posted about 1 month ago
Buenos días me encanto tu desarrollo, un tip que tal vez ya lo sepas pero igual no esta de mas mencionarlo podrias hacer los input de forma dinamica con JavaScript. saludos!!!
0 - @dejuliansrSubmitted about 1 month ago@JJorgeMS13Posted about 1 month ago
Me gusto mucho tu desarrollo, auque podrias mejorarlo poniendo un slider en mobile y revisar un poco el diseño ya que en 320px hay algunos elementos que se ven extraños y para tener un poco mas de acessibilidad podras usar mas elementos buttons y menos divs
0 - @aouintihouariSubmitted about 2 months ago@JJorgeMS13Posted about 2 months ago
Podrias cambiar el diseño también cuando este en Focus el elemento asi el diseño se vería mas acorde al diseño en vez de dejar los elementos con el focus predeterminado al igual te falto agregar un elemento a para los titulos de las tarjeta.
0 - @aouintihouariSubmitted about 2 months ago@JJorgeMS13Posted about 2 months ago
Podrias mejorar el diseño en dispositivos pequeños, ya que al ponerle en 320px y darle click sin llenar nada el desarrollo colapsa por que no se ve por completo el formulario, saludos! lo que yo hago es poner el height: 100% en los contenedores y no dar height ni width a mi card, por que con los padding y margin tu los puedes ir controlando.
0 - @cassiopeia001Submitted about 2 months ago@JJorgeMS13Posted about 2 months ago
you could use HTML semantico para hacer el accordion, the tag
<details> <summary> here write the question and image </summary> here write the answer </details> i hope you enjoy, grettings!!!Marked as helpful0 - @dejuliansrSubmitted about 2 months ago@JJorgeMS13Posted about 2 months ago
you could use HTML semantic for don´t use div, this help in the accessibility, also use in :root { font-size: 62.5%; } for you could use 1rem = 10px and this makes it easier the conversion. greetings!!!
0 - @ArcloanSubmitted 2 months agoWhat are you most proud of, and what would you do differently next time?
I managed to complete the task completely on my own in about 10 hours.
What challenges did you encounter, and how did you overcome them?The variable naming and the function naming in the js file need a lot of improvement. The functions I defined maybe are too big in scope. I should have broken them down in more meaningful pieces. I don't know if the overall logic of the js file is good or there is a big space for improvement. With this challenge I understood the repay of writing mantenable css. To change the theme I had to redefine a big part of the file, and I had to boost the specificty on certain selector to work. The overall specificity in some part of the file was too high. I'm happy and frustrated at the same time. Anyway I can't wait to continue my learning journey.
What specific areas of your project would you like help with?If anyone has any suggestions on the challenge I encountered, which I described above, I will be very grateful. I started my journey in web development 4 months ago and I don't know if I am on the right track or I'm behind. Any other suggestions are welcomed too. Thank you all.
@JJorgeMS13Posted about 2 months agoMe encanto tu desarrollo, podrias usar const en vez de let cuando declares tus objetos que solo vas a ocupar para la logica y esos objetos los mandas como parametros para poder hacer mas limpias tus fucniones, espero y te sirva, saludos!!!
0 - @roidzuhSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
React, Tailwind CSS, mobile-first approach
What challenges did you encounter, and how did you overcome them?none
What specific areas of your project would you like help with?Any feedback is welcome!
@JJorgeMS13Posted 2 months agoyour layout i liked it, but the interaction with user could be best if when give click in the checkbox and change the states of strength.
0 - @thusmileySubmitted about 2 years ago@JJorgeMS13Posted 2 months ago
Podrias poner mas puntos de interrupción y hacer que tus centenedores se centren en la mitad de sus padres esto es muy facil con display: flex; y sus propiedades align-item y justify-content
0 - @ShubhamOulkarSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I learned :has() pseudo class in this project. Also I learned how to write less CSS. In JavaScript VALIDATION_STATE is used to validate input fields and values. I have written state management functions in this project.
What challenges did you encounter, and how did you overcome them?State management was little challenging.
What specific areas of your project would you like help with?I want help on my JavaScript code.
@JJorgeMS13Posted 2 months agoMe encanto como resolviste tu proyecto y que tu codigo esta bien entendible.
0 - @yazid78Submitted 3 months agoWhat are you most proud of, and what would you do differently next time?
i learn to use css grid
@JJorgeMS13Posted 3 months agoMe gusto mucho como resolviste tu desafio, yo solo le pondria un poco mas de puntos de interrupción para que fuera menos drsatico el cambio entre pantallas.
0