@YacineBedjSubmitted 12 months ago
Julius Blezinger
@JBleziAll comments
- @JBleziPosted 12 months ago
Hey Yacine, looks great and works great overall!
I see you are a fan of very slim margins and paddings overall, maybe you can lighten it up by just doubling the outer margin on mobile and also the padding of the cards?
Also you can give the menu dropdown a little bit of a shadow as well, that way it's easier for the user to distinguish. That's really minor though.
Hope this helps :)
Marked as helpful0 - @byNico1Submitted 12 months ago
I am practicing my frontend skills I would like feedback on:
how can I improve my javascript code? because I think it could be improved but without a framework just vanilla JS as I did it
@JBleziPosted 12 months agoHey Nicolas, looks really great! Love the rounded edges and the overall subtle but effective styles. Shopping cart also works flawlessly. The only little thing I noticed is that when you hover on the profile pic, the border of the avatar is pushing the shopping cart icon to the side. You can easily fix this by deleting the content-box property from your avatar:
.avatar:hover { /* box-sizing: content-box; */ <-- DELETE THIS border: 3px solid var(--orange); border-radius: 50%; }Hope this helps :)
Marked as helpful0 - @DruxAMBSubmitted 12 months ago
Learning routing, theme color change and using tailwindcss with vite.
@JBleziPosted 12 months agoHi DruxAMB, you got the gist of it down, looks good overall. The region filter doesn't quite seem to work yet, maybe you can have a look what went wrong there. Always test your app extensively before deploying.
Also, just some tip for the colors, especially on dark mode. Pick a slightly lighter color for the cards than for the background, just so the cards are visible a little bit better. And I noticed that when you search for a country the container div for the result has the right background color, but the body does not. Make sure, the body also has the right background color.
Hope this helps :)
0 - @jen67Submitted 12 months ago
Hey awesome folks! 🌟 Just wanted to share my excitement—I just wrapped up this cool dropdown navigation homepage challenge. 🚀 While figuring out the dropdown positioning, I faced a bit of a challenge, but I managed to tackle it in the end! 🎉 It might not be flawless, but I'm still in the learning zone. 📚💡 Open to any tips or corrections you might have! Let's learn and grow together! 🌱💪😊
@JBleziPosted 12 months agoHi Gift! It looks great overall, really good work :)
Apart from the advice already given by Matias, the only thing I would change is that you can make it so the menus close when you open another menu, so when the 'Features' menu is open and you click on the 'Company' menu, then the 'Features' menu closes. This helps the user focus better on the menu they just clicked on.
By doing that it is also easier to align the dropdown with the menu item, because then the other dropdown won't be in the way ;)
Hope this helps, keep up the good work!
Marked as helpful1 - @mu-abbasSubmitted 12 months ago
I am happy to share my first solution with you, and i need some comments on:
- handling keeping the mention during updating a reply.
- A solution to animate order property of Flexbox.
- View classes structure.
- My MCV structure and general discussion about my code.
@JBleziPosted 12 months agoWow, looks amazing! I like how you added another Reply button to the replies as well, which was kind of missing from the project description. The little blend in animations for new comments are also really smooth and pleasant. The only thing I would change is to limit the likes and dislikes to a maximum of 1, as it is usually not possible to give an infinite number of likes per user. Overall super impressive though!
Marked as helpful1
