P
Abdessalam Barka• 430
@barka-dev
Submitted
P
JA-307020
@JA-307020
All comments
I like how responsive the page is and how you used variables and some unusual pseudo-selectors like :not. However I believe that the <section> within a <section>, all within an <article> is a bit redundant. Basically if the whole page is an article then you can use individual sections, no need to wrap everything in another section. Hope that makes sense. Thanks for reading and keep up the good work! :)
0- Virshree Desai• 100
@Virshree
Submitted
What are you most proud of, and what would you do differently next time?
I am proud of finishing this challenge
What challenges did you encounter, and how did you overcome them?
No challenge
What specific areas of your project would you like help with?
Nothing
Your version looks very responsive especially on small devices. However, you forgot about the hover state on buttons. Overall, it looks great, but it needs a bit of adjustment to fit the design. Keep it up! :)
0 - Kapkrazy• 190
@Kapkrazy
Submitted
What are you most proud of, and what would you do differently next time?
Finished the project in a much quicker time
What challenges did you encounter, and how did you overcome them?
I encountered a problem with trying to make a block element an inline element which was quick to fix.
What specific areas of your project would you like help with?
semantic html and accessibility and structuring my css better.
Your version looks a little smaller, but in fairness it's kind of difficult to produce 100% design while maintaining responsiveness. Great solution by the way, keep it up!
Marked as helpful
0 - PAkshay Jain• 50
@i-rebel-aj
Submitted
What are you most proud of, and what would you do differently next time?
This is after a long time I've worked with CSS at all. Excited to see more projects.
What challenges did you encounter, and how did you overcome them?
Took quite some time to figure out how to center the card. I did made the body flexbox, made height 100vh and aligned item on center on both the axis.
What specific areas of your project would you like help with?
Some Code review would be nice, I had a sense I could arrange my card components well, to have a reusable styling.
Your solution looks pretty close to the design requests, congrats!
0
