Skip to content
OverviewSolutions
6
Comments
3
Al Imran
@ImranAvenger

All comments

  • Eileen•20
    @leenishereSubmitted almost 4 years ago

    First time using Gatsby/ReactJS to build a static page. Do let me know if there is any improvements that can be made. Thanks!

    Gatsby

    1
    Al Imran•135
    @ImranAvengerPosted almost 4 years ago

    Hi Eileen, your site is looking pretty well. But you should have coded with only recommended elements like HTML, CSS grid. Otherwise, it's well. And another thing that is so noticeable that you're reported by many HTML issues, you should fix these issues. Thank you, go ahead! N.B.- If you find any valuable points in the feedback comments, it is better to upvote the comments.

    0
  • Al Imran•135
    @ImranAvengerPosted almost 4 years ago

    Hi Allan, it is so amazing! You could have used an external CSS file by link tag. Inside the class of cardProfile, the value of border-radius you can write 50% instead of 50px. Then it will be round perfectly. And everything is okay, go ahead! Thank you...

    0
  • Aakash Bansal•20
    @Aakash962002Submitted almost 4 years ago

    how is the design if any changing required that tell me

    boostrape

    1
    Al Imran•135
    @ImranAvengerPosted almost 4 years ago

    Hi Aakash, your site is looking quite good. But you have to improve your coding style and have to be more careful, such as first you could have used the header image as a background-image. And then you have to fix your HTML issues like inside your img tag that is alternative text, it is missing alt attribute. And another thing is very noticeable, when I hovered my mouse pointer on navlink was being moved, it looked so ugly. I think if you fix the background image as well as rewrite the better nav formation, it'll be better. Secondly, your every sections' measurement has to be absolute, especially height. Finally you haven't coded your site mobile and other devices friendly, you have to do responsive your code.

    1