Ibtehaj Ali Mirza
@Ibtehaj-Ali-1All comments
- @faekhatamiSubmitted 3 months ago@Ibtehaj-Ali-1Posted 3 months ago
It would help if you worked on making the web pages Responsive at different breakpoints...
0 - @faekhatamiSubmitted 3 months ago@Ibtehaj-Ali-1Posted 3 months ago
Everything is Perfect!! It would be great if you make it interactive using Javascript. ✨
0 - @AdamullaOsasSubmitted 3 months ago
- @faekhatamiSubmitted 3 months ago@Ibtehaj-Ali-1Posted 3 months ago
It is looking great and working well!! It would help if you worked on Gradients and Flex and Grid properties. You can use Flexbox to center your container:
body { display: flex; align-items: center; justify-content: center; }
Or You can use Grid!
Marked as helpful2 - @Ayomide-PhilipSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
Being able to manipulate my code to look somehow like the original design
What challenges did you encounter, and how did you overcome them?i cant really say
What specific areas of your project would you like help with?i cant really say
@Ibtehaj-Ali-1Posted 3 months agoIt would be best to work on
padding
,margin
, andcolor
properties...0 - @Lescano713Submitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud of using fetch to retrieve data. Next time, I plan to implement functions to break the code into smaller, reusable pieces.
What challenges did you encounter, and how did you overcome them?When I tried to separate the code, I had trouble determining which parameters to use.
What specific areas of your project would you like help with?I need practice in breaking down my code into functions to improve organization and readability. By separating the code into distinct functions, I can make it more modular, maintainable, and easier to debug.
@Ibtehaj-Ali-1Posted 3 months agoLooking Great! Increase the spacing between the objects and it will increase the size if
height
is set toauto
.0 - @faekhatamiSubmitted 3 months ago@Ibtehaj-Ali-1Posted 3 months ago
Looking Great!! But you can adjust some things like...
- Increase the
padding
of the card and add space between the main content and the image. - Reduce the
font-size
and decrease the size of the tick mark SVG. - And increase the overall size of the card.
1 - Increase the
- @JamesYcodeSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I am proud of understanding grid layout system more and I work on these projects. Next time I would use more shorter grid syntax.
@Ibtehaj-Ali-1Posted 3 months agoAdjust the Grid container's size and decrease the drop-shadow opacity.
0 - @z-mnSubmitted 3 months agoWhat specific areas of your project would you like help with?
All feedback is appreciated.
- @faekhatamiSubmitted 3 months ago@Ibtehaj-Ali-1Posted 3 months ago
Looking pretty good! But there are some things out of place...
- There is not enough bottom padding in the first (purple) card and the quotation SVG or PNG is also close to the border.
- There is also not enough bottom padding in the Gray and White card.
1 - @innitmanSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
Practising making the HTML as semantic as possible and thinking of aria
What challenges did you encounter, and how did you overcome them?SVGs!
What specific areas of your project would you like help with?- SVG - I ended up just pasting it as an inline in the end. I struggled with the other method of using with the svg as a src. I've read about the viewbox, but I could'nt make it fit correctly. The "intrinsic" height and width on the raw svg seems to be width="15" height="16", but clipped the image. I tried removing one of width or height and it didn't work either.
I tried using https://developer.mozilla.org/en-US/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web and mirroring
It might be something to do with viewboxes I feel, but I can't quite figure out how to use the with the svg as src in this case - any help would be much appreciated :)
@Ibtehaj-Ali-1Posted 3 months agoEverything is looking great. Just work on
font-size
andmargin
between every element.1 - @Lescano713Submitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud of how I implemented CSS Grid properties to achieve the solution.
What challenges did you encounter, and how did you overcome them?I tried to avoid using media queries, so I used CSS Grid, but I encountered problems when the screen size was reduced. The content transformed into columns, which was fine, but there was no space between the content and the body.
What specific areas of your project would you like help with?I would like to get feedback on how I can create a responsive page using only CSS Grid without media queries
@Ibtehaj-Ali-1Posted 3 months agoEverything is looking great. Just increase the spacing between the Original and Discount prices and increase the
margin-top
andmargin-bottom
to theprice-product
.Marked as helpful0