Skip to content
OverviewSolutions
6
Comments
4
Hugo Albuquerque
@HugoAlbuquerque1993

All comments

  • Richard•320
    @riwepoSubmitted about 1 year ago

    Hi, I would love some feedback on this project.

    The parts I found the hardest -

    • setting up Vite for the first time there are lots of bits to get right
    • writing tests for the parsing of the JSON input from the RestCountries API while using Typescript, where the incoming data is of unknown type
    • what behaviors to implement for the search input

    I have one specific question - I implemented 'dark mode' with Tailwind. It worked perfectly on my desktop but on my mobile the dark and light themes were reversed i.e. the colors were dark when dark-mode was off and vice versa. No idea why???

    Rest Countries API build with React, Typescript, Tailwind, Vite

    1
    Hugo Albuquerque•160
    @HugoAlbuquerque1993Posted about 1 year ago

    Maybe it's because you're collecting the device's theme preference. If you are not doing this, I suggest you start doing it to try to solve the problem.

    1
  • Hugo Albuquerque•160
    @HugoAlbuquerque1993Posted about 1 year ago

    The site preview link is not working =/

    2
  • Fabian•150
    @slowjoSubmitted about 1 year ago

    Span without text-decoration inside a paragraph that has text-deco?

    For the part that shows the large, green updated price and the crossed-out old price next to it, I wanted to style the whole paragraph with text-decoration: line-through; and then just have a span inside this paragraph that has all the large text and color styling, and text-decoration: none;

    However, it seems this is not possible, since text-decoration: none; did not get rid of the line through the updated price. Eventually I just styled the whole paragraph green and with large text and had the small, crossed out part in a span with text-decoration: line-through;

    It is actually easy to do it like this but I was still wondering if anyone has encountered a similar problem with a span inside a styled paragraph where you could not 'undo' the paragraph styling inside the span? Or do you have a neat solution for this type of issue?

    Responsive Product Preview Card

    1
    Hugo Albuquerque•160
    @HugoAlbuquerque1993Posted about 1 year ago

    Pay attention to responsiveness between 750px and 900px. Other than that, it's perfect.

    0
  • Hugo Albuquerque•160
    @HugoAlbuquerque1993Posted about 1 year ago

    O layout do desktop ficou idêntico, muito bom! Porém o layout mobile ficou bem desproporcional, nada agradável ao usuário final. Se quiser uma dica: Captura automático o IP do dispositivo que está acessando o app no instante que ele o abre, e depois o usuário troca o IP conforme a proposta do app.

    Marked as helpful
    0