All comments

• 

  Hibiscuit• 30

  @Hibiscuit0

  Submitted almost 2 years ago

  Hi,

  I've seen that at some screen sizes, my footer comes next to my main component and I don't understand why (for example, on Edge "Nest Hub" screen 1024 x 600 and on my Samsung galaxy S7). I guess that it is because of my flexbox but I don't understand the reason of this problem.

  Do you have any clue why it is happening ?

  Thanks a lot

  

  Hibiscuit0 NFT component

  2

  30

  

  Hibiscuit• 30

  @Hibiscuit0

  Posted almost 2 years ago

  Thanks for your advice. It works. I had a confusion with the wrapping notion: it was absolutely not needed to wrap.

  But I still don't understand why the footer wrapped since I defined its width of 100vw, so there is still some concepts to learn..

  0
• 

  Hibiscuit• 30

  @Hibiscuit0

  Submitted about 2 years ago

  Hi,

  I'm a newbie to front-end dev. For this challenge, my main question is about how to vertically center the card ? Is my way doing that efficient enough ?

  Thanks for your advices

  

  Hibiscuit0 Newbie QR code component

  4

  40

  

  Hibiscuit• 30

  @Hibiscuit0

  Posted almost 2 years ago

  Thanks a lot @Mauger1998 @jhellard and @correlucas for the advices.

  I've seen that for accessibility, I should have used semantic tags --> I'll try to take this into account for each new challenge. I don't know yet the grid --> I'll try !

  The difference between width and max-width seems to be important to know, so thanks for the explanation.

  Next time I can work on it, I'll correct my code to fit your advices.

  0