Hassia Issah
@HassiaiAll comments
- @RalphdanySubmitted over 1 year ago@HassiaiPosted over 1 year ago
There is no need to style the main give its background-color to the body
To center .container on the page using flexbox or grid instead of giving it a margin value, Add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body OR add min-height:100vh; display: grid place-items: center to the body
- USING FLEXBOX:
body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
- USING GRID:
body{ min-height: 100vh; display: grid; place-items: center; }
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
1 - @tamasgazdikSubmitted over 1 year ago
No specific questions, but any improvement idea is much appreciated :)
@HassiaiPosted over 1 year agoTo center .container on the page using flexbox, add
align-items: center
to the body.body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
There is no need to style the main and to give .container a margin value.
Reduce the font-size of h1 to 1.25rem which 20px.
Replace the margin-inline in h1 and p with margin-top, margin-right and margin-left of 1rem.
h1, p { margin:1rem 1rem 0;}
orh1, p{ margin-top: 1rem; margin: 0 1rem}
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful1 - @TaruHamalainenSubmitted over 1 year ago@HassiaiPosted over 1 year ago
The styling you gave to the buttons hover effect should be the button styling an its styling should be the hover effect.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0 - @LucianEmanuelSubmitted over 1 year ago
I appreciate any feedback
@HassiaiPosted over 1 year agoReplace <div class="card"> with the main tag to make the content/page accessible. click here for more on web-accessibility and semantic html
For the color of the image change the value of the mix-blend-mode in the img to multiply and opacity to 0.8
mix-blend-mode: multiply opacity: 0.8
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0 - @Destyx-9Submitted over 1 year ago
Had some issues with the hover on the image with the opacity but I managed to figure it out, maybe not the best way to do it, I'm curious to know how you would have done it!
@HassiaiPosted over 1 year agoEvery html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.
To center .container on the page using flexbox or grid instead of giving it a margin value, Add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body OR add min-height:100vh; display: grid place-items: center to the body
- USING FLEXBOX:
body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
- USING GRID:
body{ min-height: 100vh; display: grid; place-items: center; }
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here
For a responsive content which wont require a media query for this challenge, give .contain a fixed max-width value.
max-width:400px which is 25em/rem
For the hover of the image, give . main-image a width of 100% and position: relative. Give .main-image img a width of 100% and display: block. Give .main-image div position: absolute, left, bottom, right and top value of 0, background-color pf cyan and opacity:0. Give .main-image img: hover .main-image div opacity: 0.9 and cursor value of pointer.
.main-image{ width:100%; position: relative; } .main-image img{ width:100%; display: block; } main-image div{ position: absolute; top:0; left:0; bottom: 0; right: 0; background-color: hsl(); opacity: 0; } .main-image img: hover .main-image div{ opacity:0.9; cursor: pointer }
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful1 - @gudon199Submitted over 1 year ago@HassiaiPosted over 1 year ago
Replace <div class="card"> with the main tag and <p class="title"> with <h1> to make the content/page accessible. click here for more on web-accessibility and semantic html
Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.
To center .card on the page using flexbox, replace the height in the body with
min-height: 100vh
.Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0 - @shauncraigdevSubmitted over 1 year ago
Learning to code.
Started on HTML + CSS currently
This is my attempt at this project, i'd rate my attempt 5/10. Thoughts to improve: better coding
@HassiaiPosted over 1 year agoTo center the article on the page using grid add min-height: 100vh to the body and remove the margin value in the body.
body{ min-height: 100vh; display: grid; place-content: center; }
there is no need to give the body and html a height value, it is not required.
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0 - @Tayyab-Basit324Submitted over 1 year ago@HassiaiPosted over 1 year ago
There is no need to give .container a width value. Change the value of the background-size to contain.
background-size: contain
To center .top on the page using flexbox, replace the height in .container with
min-height: 100vh
.For a responsive content, replace the width in .top with max-width and increase it value for it to be equivalent to the design.
max-width:432px which 27rem/em
This challenge requires a media query, in the media query you only have to change the background-image of .container. For more on media queries, click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0 - @zachtixSubmitted over 1 year ago@HassiaiPosted over 1 year ago
Replace <div class="card"> with the main tag to make the content/page accessible. click here for more on web-accessibility and semantic html
To center .card on the page using flexbox, replace the height in the body with
min-height: 100vh
.For a responsive content, give .card a max-width of 1440px and a width of 80% or a width of 80vw instead of giving it a width of 144p0x.
To prevent the content from overflowing on smaller screens, remove the height value in .card
For the color of the image, change the value of the mix-blend-mode in the img to multiply and opacity to 0.8
miix-blend-mode: multiply; opacity: 0.8
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
0 - @Hng8Submitted over 1 year ago@HassiaiPosted over 1 year ago
Replace <div class="product-preview "> with the main tag and <h3> with <p> to make the content/page accessible. click here for more on web-accessibility and semantic html
The body has a wrong background-color,
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0 - @MosesgoodSubmitted over 1 year ago@HassiaiPosted over 1 year ago
Replace <div class="boxes"> with the main tag to make the content/page accessible. click here for more on web-accessibility and semantic html
Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.
To center .boxes on the page using flexbox or grid, dd min-height:100vh; display: flex; align-items: center: justify-content: center; to the body OR add min-height:100vh; display: grid place-items: center to the body
- USING FLEXBOX:
body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
- USING GRID:
body{ min-height: 100vh; display: grid; place-items: center; }
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here
There is no need to give the body a margin value.
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
0 - @erlanggaadptrSubmitted over 1 year ago@HassiaiPosted over 1 year ago
To center .card on the page using flexbox, replace the height in the main with
min-height: 100vh
.Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful1