Skip to content
OverviewSolutions
5
Comments
4
Hartmannsgruber Benjamin
@HartmannsgruberBen

All comments

  • Pedro Poliszuk•60
    @pedropoliszukSubmitted 2 months ago
    What are you most proud of, and what would you do differently next time?

    I think I made a good job with semanthic html.

    What challenges did you encounter, and how did you overcome them?

    I had difficulties because the design showed padding before the body, but I managed to replicate it in my project

    What specific areas of your project would you like help with?

    I had problems making the image with a better size in the version below 639px

    Recipe page

    1
    Hartmannsgruber Benjamin•120
    @HartmannsgruberBenPosted 2 months ago

    The table at the end contains a line under the last entry. You can solve such a problem with pseudo-classes like tr:not(:first-child) td {}, which allows you to set propertys on elements which matches the case. https://www.w3schools.com/css/css_pseudo_classes.asp

    Marked as helpful
    0
  • Hartmannsgruber Benjamin•120
    @HartmannsgruberBenPosted 2 months ago

    Do not use <br> in your html to generate spaceing. You can use the "gap" property of a flex layout to add space between each item. The Text "Front-end ..." is missing some font-weight, but thats not essential. The html is clearly structured. The styles are structured logical.

    Marked as helpful
    0
  • Hartmannsgruber Benjamin•120
    @HartmannsgruberBenPosted 2 months ago

    use the colors from the given file. The dimensions were also a bit tricky for me.

    0
  • Hartmannsgruber Benjamin•120
    @HartmannsgruberBenPosted 2 months ago

    the html includes correct HTML The centering could be simplyfied by flexbox (justify-content,...) The content looks good The code is readable and well structured

    Marked as helpful
    0