Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • Eugen• 200

    @psdesignro

    Submitted

    What are you most proud of, and what would you do differently next time?

    I haven't used CSS grid for a while, but I'm glad I managed to do it correct from start. Of course, I have chosen the most basic approach, but I will refine my CSS grid skills for the next projects. I also start to understand better the use of SASS and how it can keep my code clean.

    What challenges did you encounter, and how did you overcome them?

    I wanted to get the most out of SASS and to use the mobile first approach. I learnt how to use @mixin for media queries and will use this approach for my further projects.

    What specific areas of your project would you like help with?

    I am ok for now, thanks

    HamzeKabi• 100

    @HamzeKabi

    Posted

    Hi bro, good job.

    You could write this: grid-template-columns: repeat(4, 1fr);

    instead of grid-template-columns: 1fr 1fr 1fr 1fr;

    Look into grid-template-areas. It's makes writing grid much easier

    Marked as helpful

    1
  • Jarmo• 80

    @Jarmovd

    Submitted

    What are you most proud of, and what would you do differently next time?

    Working with grid went really well and it was easy to develop mobile first. Next time I would like to make it full responsive and not only mobile 375px and desktop 1440px.

    What challenges did you encounter, and how did you overcome them?

    Had to look into grid-row and grid-column some more to position the desktop version but after little research it went smoothly.

    What specific areas of your project would you like help with?

    Any feedback is welcome!

    HamzeKabi• 100

    @HamzeKabi

    Posted

    good coding

    0
  • Patricio Zarauz• 140

    @PatricioZarauz

    Submitted

    What are you most proud of, and what would you do differently next time?

    What I'm most proud of is the mobile first approach that I had during the whole challenge and also that I made the component as accessible as I could off.

    What challenges did you encounter, and how did you overcome them?

    The main challenge I encountered was regarding the html structure and tags to use, in order to make it as semantically as possible. What I did to overcome this is read a lot of articles online, regarding what the best tags to use in this particular case was. This is one of the articles that helped me out

    What specific areas of your project would you like help with?

    I would like to get some feedback regarding on how to cleanup or simplify the code and how to make it more accessible. Also some help on how to fix the preview error that I'm having.

    HamzeKabi• 100

    @HamzeKabi

    Posted

    your solution is different from the design

    0
  • gabgonsan712• 90

    @gabgonsan712

    Submitted

    What are you most proud of, and what would you do differently next time?

    I was proud that I was able to build the proyect with ease and speed, a sign that I have improved my knwoledge.

    What challenges did you encounter, and how did you overcome them?

    My only problem was solving the spacing of the lists, between the bullet point and the text, I solved it using stackoverflow

    What specific areas of your project would you like help with?

    None

    HamzeKabi• 100

    @HamzeKabi

    Posted

    I use scss as well, you made a good use of saving variables and mixins in separate file. But why you did not design the mobile version

    0
  • HamzeKabi• 100

    @HamzeKabi

    Posted

    it's Good bro, liked it

    0
  • HamzeKabi• 100

    @HamzeKabi

    Posted

    Perfect work, learned a lot from your codes

    I have a few question, I'd be very grateful if you could answer them

    1. Why did you create the svg when it was already available in assets folder?

    2. How did you create the svg? did you create it purely by writing or used a program?

    3. Is it a good practice to apply box-sizing:border-box to all elements?

    Thanks a lot

    0
  • HamzeKabi• 100

    @HamzeKabi

    Posted

    For aligning an element at the center vertically I used the following snippet: display: table; position: absolute; top: 0; bottom: 0; right: 0; left: 0; margin: auto; whereas TomasevicMarko used: display:flex; justify-content:center; align-items:center; height:100vh I think his solution is better. Also I used internal style, while he used external

    For writing texts the way they were displayed, I used: white-space: pre-wrap whereas he used box-sizing: border-box, and specifying its width and height. His solution is the right one

    0