Guillaume Ventura
@HLIFTAll comments
- @shon242Submitted 3 months ago@HLIFTPosted 3 months ago
The design is well integrated overall, and the code is clear and well-structured. However, there are some design details that could be improved. For example, the font has not been integrated as specified, and the
padding
in card andborder-radius
on image do not match exactly with those in the Figma file.Additionally, there’s a responsive issue with the current media queries. Instead of using
@media only screen and (min-width: 375px)
for mobile styling, it would be better to use@media only screen and (max-width: 1440px)
. Themin-width
approach applies the mobile styles to screens that are at least 375px wide, which means these styles will also be applied on larger screens, like desktops. As a result, desktop styles such as font sizes may not display correctly.Good work overall!
Marked as helpful0