Skip to content
OverviewSolutions
3
Comments
3
P
Godskitchen
@Godskitchen

All comments

  • Godskitchen•50
    @GodskitchenPosted 3 months ago

    Hi, your layout seems perfect. Thanks for the links in your repo description

    1
  • Charles•90
    @Ghost-Writer-2Submitted 3 months ago
    What are you most proud of, and what would you do differently next time?

    I was able to learn from the mistakes I made in my previous project and I was able to complete this project a little faster

    What challenges did you encounter, and how did you overcome them?

    I'm still trying to learn how to create responsive layouts

    What specific areas of your project would you like help with?

    I'd like to know some best practices from more experienced front-end devs and better ways to attempt the challenge.

    Semantic HTML5 markup, CSS custom properties, flexbox

    1
    Godskitchen•50
    @GodskitchenPosted 3 months ago

    hello! I think that you can set width: 100% to html and body tags to align card on center. Remove unnecessary margins, and reset it in first selector:

    • { box-sizing: border-box; margin: 0; padding: 0; }

    It is standard feature to make pixel-perfect layout.

    Marked as helpful
    0
  • Godskitchen•50
    @GodskitchenPosted 3 months ago

    Hello, you can apply "height: 100%" to "html" and "body" tags. It let you to align the card in center. Also you should check the template sizes, you have the wrong ones.

    0