Skip to content
OverviewSolutions
10
Comments
7
Girma
@Girma3

All comments

  • Yohannes Merete•310
    @YohannesDreamSubmitted 8 months ago
    What are you most proud of, and what would you do differently next time?

    Hi everyone, I just completed another project and would love to get your feedback. Thanks in advance for your help!

    Responsive Huddle Landing Page

    1
    Girma•300
    @Girma3Posted 8 months ago

    Hi Yohannes, you build great landing page well done and just to give you simple feedback when you use links with no address add aria-label for accessibility in your case you have three links in footer example for twitter add aria-label="twitter" and so on also in future when you have buttons that doesn't have no name but symbols only such as previous(<) and next(>) button etc add aria-label and keep up with the great work 💪

    Marked as helpful
    0
  • Girma•300
    @Girma3Posted 8 months ago

    Hi Yohannes , you build cool card and If I have to be neat pick based on my opinion add hover effect on the button or on the card to make it interactive overall nice job.

    0
  • Girma•300
    @Girma3Posted 9 months ago

    Hi @ayomikuolarewaju , I may have these feedbacks when the screen size shrink the article and slider buttons are in wrong position ,in big screen the article moved to the right and it get cutted or overflow so decrease the padding and margin on the left side of the article and you can add slider functionality since you almost finished and put all the things there and it makes it better , you got this and happy coding.

    0
  • CairoGarb•810
    @CairoGarbSubmitted 9 months ago

    +1 project done! I have a few question regarding a few aspects of this challenge.

    1. Is there a better way to make the curved sections?
    2. How can I change the text ("Check your email please") or whatever aspect of the input when is invalid without using JS?
    3. How to use the Form tag properly?

    Any tips/feedback will be appreciated, thank you!

    Responsive Huddle Landing Page with Curved Sections

    1
    Girma•300
    @Girma3Posted 9 months ago

    It looks very good well done. and to answer your question number 2 to validate input without js use html constraint validation like (required, minlength,maxlength..according to your input then when this value not meet css :invalid class will match if it correct :valid class match so you can use css .see this resource for more (https://developer.mozilla.org/en-US/docs/Web/HTML/Constraint_validation ) and also client side form validation.

    Marked as helpful
    0
  • Girma•300
    @Girma3Posted about 1 year ago

    Nice job on your sign up form and in my opinion you can make it better by showing typed email on success message and when dismiss button pressed turn back to the sign up form .

    0
  • Girma•300
    @Girma3Posted about 1 year ago

    Hi Rosario it is nice form and I think you can make it better in my opinion by resizing the input it take full screen and make the cards too small.

    0
  • Girma•300
    @Girma3Posted about 1 year ago

    It is very nice sign up form good job and in my opinion you can make it even better by hiding the form after the user submit it then show the success message after that.

    0