@saulgutierrezSubmitted about 2 months ago
GiorgiOsha95
@GiorgiOsha95All comments
- @GiorgiOsha95Posted 26 days ago
Good documentation and the end result looks similar, You need to be more attentive to details ( Too much spacing between the card and title, Shadows for cards are hard to see compared to design ), Everything else looks great, Good job
0 - @GustavoSDSSubmitted 2 months agoWhat are you most proud of, and what would you do differently next time?
Quedó muy bien la página, como lo muestra el diseño.
What challenges did you encounter, and how did you overcome them?Ningun desafío encontrado.
What specific areas of your project would you like help with?En ninguna.
@GiorgiOsha95Posted 2 months agoGood job, the end result looks fantastic the same as the design
1 - @SultanFarrelSubmitted 3 months ago@GiorgiOsha95Posted 2 months ago
Great job with the Tailwind CSS implementation! I noticed that the solution works well for both desktop and mobile versions. However, it breaks between screen resolutions of 640px and 1024px due to the max-w property. To improve responsiveness, you can either remove the max-w property in the container class for the 640px and 768px breakpoints or overwrite it using Tailwind utilities, for example: !max-w-full for smaller screens and lg:!max-w-[640px] for larger screens. This adjustment should ensure the design looks great across all resolutions.
0 - @PetrakoowSubmitted 2 months ago@GiorgiOsha95Posted 2 months ago
Semantic HTML: The code effectively uses semantic HTML elements, which enhances clarity and accessibility.
File Categorization: The file organization is good and understandable, though it may be slightly complicated for a small project. Simplifying the structure could improve maintainability without sacrificing clarity.
Mixins Usage: The use of mixins is well-executed and demonstrates good practice, especially for larger projects. They help in maintaining consistent styling and managing complexity.
Marked as helpful1 - @rcsilva211Submitted 2 months agoWhat are you most proud of, and what would you do differently next time?
I believe I did a good job in replicating the page and I'm happy with the result. I'm very open to constructive feedback!
What challenges did you encounter, and how did you overcome them?Making the semantic seem right and organizing the code. Basically I did double check while trying to be unbiased about
What specific areas of your project would you like help with?Help and feedback with best practices and what can I improve with.
@GiorgiOsha95Posted 2 months agoGood job, Really close to the design , for cleaner code wriiting i would say to write classes and tags on 1 line
html, body {} like this instead of html,body {}1 - @Crocoboy000Submitted 3 months ago@GiorgiOsha95Posted 2 months ago
Good job, without figma files it's hard to judge the size of spacing but you can bring it as close to the picture as possible by compering how many lines text takes and where it has word wrap, shadows don't have enough definition, good and simple css
0
