All comments

• 

  Jose Gabriel•80

  @JGabriel19Submitted 12 months ago

  All comments are welcome, thank you.

  

  QR Code Component

  1

  41
  

  Giovani Oliveira•80

  @GiodosvaniPosted 12 months ago

  Nice solution! Just one unique thing, but nothing to serious: You don't need to set "font-weight: 400" unless you've changed it somewhere else. The default is already 400. Continue with the good work ;)

  1
• 

  Dev.Ng•50

  @DweirdgeminiSubmitted over 1 year ago

  styling the <p> tag gave me a serious problem, I am yet to do that and also the google font is giving me issues

  

  QR CODE COMPONENT

  1

  60
  

  Giovani Oliveira•80

  @GiodosvaniPosted over 1 year ago

  Heyy, good night ;)

  So, u don't need to add a 'class = img' to a <img> tag. You can still customize it on CSS just by using the "img {...} " (without the ".") and it will work -- also work to all imgs that are in your HTML document at same time, but in this project is just one. --

  in the CSS font-size, i've seem u used "small". It works fine, but if you want more control about it, you can use numeric values for "rem", "em", "px" and others... just like this:

  h3 { font-size: 2rem; } (i've heard that px aren't recommended to font-sizes because it is an absolute value.)

  and a tip about the centering vertically in flexbox: Add a "min-width: 100vw;" and "min-height: 100vh;" to your parent (in this case, "body") This will make the container fit the size of the screen that the user is using.

  if you not set the height to fit all the screen, it will use the min-value to fit the content, so it will not give the space to center vertically on the screen.

  hope it works fine, thank you for reading and sorry if i take it too long <3

  Marked as helpful

  0