Skip to content
OverviewSolutions
24
Comments
19
Gerri Ezeocha
@GerriEzeocha

All comments

  • Gerri Ezeocha•460
    @GerriEzeochaPosted over 2 years ago

    Well done Guido! My suggestion is to check your 'snippet'( your class name seems to thirdtext) section again. your text content is off. I don't think you need those span elements in there. Also it is recommended to use the 'div' element to generally group content for styling specifically while 'section' markup simply helps with the 'outline of a page.

    keep up the good work.

    Marked as helpful
    0
  • Gerri Ezeocha•460
    @GerriEzeochaPosted over 2 years ago

    Any feedback is welcome (especially page view on different screens)! it seems fine everywhere else, but preview on frontendmentor seems off on the bottom.

    0
  • Gerri Ezeocha•460
    @GerriEzeochaPosted over 2 years ago

    Not sure what you mean, but have you considered using css animation to 'transform' on hover? that way you can set the height and width you want!

    0
  • Gerri Ezeocha•460
    @GerriEzeochaPosted almost 3 years ago

    This looks good, well done! I noticed you used 'SVG/paths' and 'Picture/src' in your html, why was this your approach and what benefits do they provide?

    Keep up the good work.

    0
  • Eugi•270
    @EugiSsSubmitted about 3 years ago

    Hello. I tried to make the page through mobile-first. I'm not very good at responsive layout yet. I made styles for 375px and 1400px only, no smooth transition. I look forward to any comments and criticism. Thanks

    FlexBox, CSS Grid, mobile-first

    3
    Gerri Ezeocha•460
    @GerriEzeochaPosted about 3 years ago

    Your desktop layout looks good, but review your responsive designs and display for mobile. As for your question the main difference I believe is that <section> is more generic tag, while <article> is more specific. check out usage notes on when to use either on https://developer.mozilla.org/en-US/docs/Web/HTML/Element/section

    Marked as helpful
    0
  • Gerri Ezeocha•460
    @GerriEzeochaPosted about 3 years ago

    This looks great Elijah! and responsive design is well done :)

    0
  • Gerri Ezeocha•460
    @GerriEzeochaPosted about 3 years ago

    Looks like you're missing your main hero section! I was looking through your src and public files and cant seem to identify the issue.

    1
  • Elisa•50
    @elisa-charrierSubmitted about 3 years ago

    At the beginning of each project, I am always undecided about which are the smartest names to give to the classes. Any suggestions? I'd be happy to check out any alternatives to the script I wrote: I'm not a pro in Javascript. Feel free to report me your solution! Thanks to who will answer.

    Time tracking dashboard: first time w/ css grid and js

    2
    Gerri Ezeocha•460
    @GerriEzeochaPosted about 3 years ago

    Great Work! Your question got me looking at naming conventions myself and it seems the BEM way is a good way to go!

    Marked as helpful
    0
  • Juan Ignacio Castelli•80
    @JuaniCaste23Submitted over 3 years ago

    Using Flex is good practice! It was made as the design was, with its respective states and with the responsive design. An eye was also added to hide or activate password text. Totally happy with this exercise !!

    The feedback is very appreciated!!. Thanks.

    Suscribe Form, my homemade solution :)

    2
    Gerri Ezeocha•460
    @GerriEzeochaPosted over 3 years ago

    Very well done Juan! I myself will be starting this exercise soon and looking forward to it :)

    Marked as helpful
    1
  • Gerri Ezeocha•460
    @GerriEzeochaPosted over 3 years ago

    Looks good William, great job! my comments would be watch the positioning of some text elements on active slides. keep up the good work!

    0
  • Gerri Ezeocha•460
    @GerriEzeochaPosted almost 4 years ago

    Love this sir! your Javascript is simple and efficient.

    1
  • Gerri Ezeocha•460
    @GerriEzeochaPosted almost 4 years ago

    Great work Juanire! What issues are you having with with your Javascript? On your preview site the toggle function is working! In terms of shortening your code, perhaps use css to change your mobile/share section and simply work on displaying with Javascript. :)

    0