@kaesle
Submitted
Do you notice any errors in my solution?
@Gerald-LeCour
@kaesle
Submitted
Do you notice any errors in my solution?
@Gerald-LeCour
Posted
Hey there π your solution and code looks great!
If you want to get rid of the accessibility reports do this:
I hope this was helpful! π
Marked as helpful
@Orliland
Submitted
What are you most proud of, and what would you do differently next time?
.
What challenges did you encounter, and how did you overcome them?
.
What specific areas of your project would you like help with?
.
@Gerald-LeCour
Posted
Wow, nice solution! π
The only thing I would do is use a main element instead of the aside element.
Other than that your solution is great! π
@Umer-Khokhar
Submitted
My solution is quit near to the design. Only one thing is confusing me that the svg icons used in designs are showing when I preview it with live server, but on github it is not showing. Can anyone tell me about this?. If yes, than please!
@Gerald-LeCour
Posted
Hey there! π
To get the icon images on your site you need to add the assets folder that came with the package you downloaded in your repository.
I hope that helped you out! π
Marked as helpful
@DFerreir4
Submitted
All feedback is welcome! Especially on mobile responsivenes work.
@Gerald-LeCour
Posted
Hey there! π Your solution looks great!
Here is some things I would recommend:
min-height: 100vh;
width: 100%;
3.Next I would use flex box to center everything, add this to your "main" element styles:
display: flex;
justify-content: center;
align-items: center;
I hope this was helpful for you! π
Marked as helpful
@MdShafiqulSaymon
Submitted
Give me some Feed Back . And Some Advice to Improve myself.
@Gerald-LeCour
Posted
Hey there π awesome solution!
If you would like to get rid of the accessibility reports you can do this:
I hope this got rid of those reports! π
@sumanth-chandana
Submitted
Happy to receive your feedback. I really appreciate any help you can provide.
@Gerald-LeCour
Posted
Hey there!π
Here are some things I would change:
border-radius: 20px;
and box-shadow: var(--Dark-gray-blue) 5px 10px 30px 0.1px;)
3.Here is some code that I made to center your div.container:
body {
display: flex;
align-items: center;
justify-content: center;
flex-direction: column;
min-height: 100vh
}
Hopefully this might have helped you! π
@G-uilhermeF
Submitted
How can I improve my CSS code, in terms of the dimensions of each div and container?
@Gerald-LeCour
Posted
Hey thereπ nice solution!
If you would like to get rid of the accessibilty and html reports do this:
Other than that I think your code looks fine!
Hopefully this helped get rid of those reports! π
Marked as helpful
@Kcalde20
Submitted
Q1: Keeping border radiuses in-sync
While I typically just eye-ball border radiuses when there is a container with one and another close element inside (in this case an image). Though I'd imagine theres some ratio that could be set in order to keep the inner radius in proportion to the out radius. Has anyone ran into a good way to factor this in? I was thinking just use a calc for the inner radius.
Q2: Extra space at the bottom of the card
I couldn't figure out what was dictating the extra padding at the end of the card in the mockups. I ended up adding a padding-block-end to make it match the style but it's unsatisfying and likely won't as nice with other lengths of content. Is there something from the design I'm missing?
@Gerald-LeCour
Posted
Hello! π
I had the same question you asked in your first question, and I found out that if you set the qr image' border radius to (border-radius: inherit;) it will proportion its border-radius to its parents border-radius and to me this seems more efficient than guessing which I was doing as well.
Hope this helped! π
@Todaymore
Submitted
Hi Everyone, I am new here, I am just curious about how you guys who are better than me in Front End Development find suitable size for any image? For example, In this QR code challenge, we have to give some value to Width and Height of the QR code, so how to find correct or more accurate size?
@Gerald-LeCour
Posted
Hey there! I was wondering this question too, I think that if you get the premium version of Frontend Mentor, then they will give you all the exact widths and heights of everything. Hope that answerd your question! :)