Skip to content
OverviewSolutions
12
Comments
4
George
@GeorgeValentin

All comments

  • Piyumi Premathilake•20
    @piyumi-1991Submitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    I hadn't deployed anything on GitHub Pages before. In this tutorial, I learned how to do it, and I'm proud of myself for learning new things every day. I also learned some new Git commands

    What challenges did you encounter, and how did you overcome them?

    When trying to deploy the site on GitHub Pages, I noticed that it was a bit difficult. However, after going through the documentation, I was able to do it successfully.

    What specific areas of your project would you like help with?

    div aligns

    QR code challenge using HTML and CSS

    2
    George•180
    @GeorgeValentinPosted 4 months ago

    Good job on completing the challenge.

    Some things that can be improved:

    • centering the component in the middle of the page
    • the size and color of the text
    • the box shadow is not applied, you need to specify a unit of measurement

    These are some ways to center the element in the middle:

    • try position: absolute; and adjust it accordingly
    • make the body display: flex; and having height: 100%;
    • there are plenty of other ways to do it, you can research on Google

    Other than that, keep up the good pace.

    0
  • George•180
    @GeorgeValentinPosted 4 months ago

    Congratulations on your first challenge.

    Some advices from me would be to revise it as the design, at least the desktop one looks a bit different from the desired result. One of the most important part of web development/design is being able to follow a design's constraints and making your final product look as close as possible to the initial desired result. You can at least get closer to how the design looks by creating a cart and centering everything, but I recommend you try to make it pixel perfect.

    Some other best practices I recommend you consider are:

    • using semantic HTML;
    • try replacing the <table> HTML tag with the CSS Grid container as the <table> element becomes a nightmare to maintain as the HTML code size increases.

    Other than that, good job on your first attempt and keep up the pace!

    0
  • Chris•110
    @cgyeagerSubmitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    .

    What challenges did you encounter, and how did you overcome them?

    .

    What specific areas of your project would you like help with?

    .

    NFT preview card

    1
    George•180
    @GeorgeValentinPosted 4 months ago

    A small advice, try to keep only CSS files related to styling and use JS only for website behavior. I know it seems like a good idea sometimes to just modify the styling inside JS, but as a project grows it becomes a nightmare to maintain. What you have done inside JS, can easily be done in by leveraging the :hover CSS pseudo-class. Use JS to adjust the styling only as a last resort. Other than that, it looks great, and props to you for being able to solve it with such few lines of code.

    Marked as helpful
    0
  • George•180
    @GeorgeValentinPosted 4 months ago

    Hi!

    A small improvement that could be a great addition is using Semantic HTML tags. Other than that the solution looks great, and props to you for making it almost identical with so little scss code.

    Great job!

    Marked as helpful
    0