Any feedback is welcome. Thanks in advance!
Geoff Walker
@Geoff-WalkerAll comments
- @KelprimSubmitted about 3 years ago@Geoff-WalkerPosted about 3 years ago
Hi
Just completed this myself it took me much longer than I had hoped. on the whole it looks good for some reason the website previewer is squashing your card but when opened in the browsers its perfect no suggestion on that one.
If you wanted some advice?
-
The box image should shift to the left during the hover event making the text red.
-
The visible question block won't hide again if you click on it again
-
Your missing the lines below each question block try adding a span with 1px height.
-
there is excessive space on the end of your container when in mobile view. I think this is caused by the media query on card
min-height: 70vh;
if you took this out and added a margin to the bottom of the missingspan:last child
that would fix that.
Hope that helps.
Kind Regards
Geoff
1 -
- @nofear1985Submitted about 3 years ago
I like feedbacks, in this way i can improve my front-end abilities! feel free to give me good constructive feedback.
@Geoff-WalkerPosted about 3 years agoLooks great the only two things I noticed is you have used a h2 and h3 element but no h1 element this is kicking out an accessibility issue. Other than its showing not vertically centered in the preview, its best part of pixel perfect. Hope that helps :-)
Marked as helpful0 - @Abd-ur-Rahman03829Submitted over 3 years ago
I can't understand how to change the color of image in css... Any suggestion about this would help me a lot... Thanks in Advance
@Geoff-WalkerPosted over 3 years agoHi try setting the background color of the image div to the purple color and then use the following settings on the actual image:
-
opacity: lower than one so you can see the background
-
mix-blend-mode: multiply;
1 -
- @rilindtasholliSubmitted over 3 years ago@Geoff-WalkerPosted over 3 years ago
Great solution Rilind congrats on getting the background images on, a lot of people stuggled with that, including me! Congrats!
Marked as helpful1