@mandrisicSubmitted 9 days ago
Gabriel Barimboim
@Gbw699All comments
- @SimonHicklingSubmitted 10 days ago
- P@imrebartisSubmitted 25 days agoWhat are you most proud of, and what would you do differently next time?
Satisfied with:
- Well-structured JS code
- Semantic HTML
- a11y features
- Use of SCSS variables and mixins
- Implementing DRY principles
- Unit testing
What I would do differently next time:
- Definitely consider using React or Next.js instead of vanilla JS
Figma:
- Challenge: the dev mode of the Figma design provided (the one that offers code snippets for implementation) is available only if you have a paid version of Figma, which I don't have ATM
- Solution: my interpretation of the design is in many cases sort of intuitive (e.g. approximating spacing)
GitHub Actions Workflow:
- Challenge: Complex deployment process with multiple checks
- Solution: Implemented staged workflow with caching
Event Handler Parameter Order
- Challenge: Inconsistent parameter order in event handlers caused bugs
- Solution: Standardized event handler signatures
Memory Leaks in Event Listeners
- Challenge: Event listeners weren't properly cleaned up
- Solution: Implemented cleanup method and unload handler
All feedback is welcome, but since this is a web accessibility project, reviewing the ARIA implementation would be the most helpful.
- P@NatentadoSubmitted about 1 month ago
- @AlfiZainSubmitted about 1 month agoWhat are you most proud of, and what would you do differently next time?
Using SCSS even though it takes me a lot time, but i like to challenge my self
What challenges did you encounter, and how did you overcome them?The challenge I faced was understanding the concepts of sass/scss, such as using @use @include and @extends, as well as modular file separation.
What specific areas of your project would you like help with?All of it, i am really appreciate your suggestion :)
- @yarsventSubmitted about 1 month agoWhat are you most proud of, and what would you do differently next time?
I'm proud of figuring out the picture element and applying the flexbox, but, in my opinion, the font styling is off.
What challenges did you encounter, and how did you overcome them?Making the picture look good, as it kept spilling out of the container.
What specific areas of your project would you like help with?Some fonts look off, how do I fix this? The colors are correct, I think, but the button is clearly different
- @dimahodanitSubmitted about 2 months agoWhat are you most proud of, and what would you do differently next time?
At first glance, this task seemed difficult. But I visually divided the page into equal sections and styled them, and then reused them. BEM methodology works great here
What challenges did you encounter, and how did you overcome them?it was difficult to find an approach to centering the block. I settled on flex box, as it allowed me to give the container side margins so that when the page is reduced, the indents would be visible
What specific areas of your project would you like help with?I would like to receive feedback and see how else this task could be implemented
@Gbw699Posted about 2 months agoHi @dimahodanit,
I've been reviewing your solution, and I think it's really great!
I have two suggestions that might help improve it:
You used <ul></ul> for an ordered list. While this isn't necessarily wrong, instead of changing the list-style property to decimal, you could simply use <ol></ol>, which is designed for ordered lists.
The flexbox layout works well on desktop, but when I view the page on mobile, the layout doesn't adapt. If you use CSS media queries alongside flexbox, you could make it more responsive.
Let me know what you think! 😊
0 - @PhillipDaumSubmitted about 2 months agoWhat are you most proud of, and what would you do differently next time?
I was proud of getting my design to look very similar to the Figma designs. I also learned how to use the @font-face rule. Next time, I will organize my CSS a little bit better.
What challenges did you encounter, and how did you overcome them?At first I struggled to use the CSS rule
@font-face. I searched up some resources from MDN and W3 schools. After that, I was able to implement it!I was also confused about the unit for "corner radius" on the Figma designs. I was able to ask a friend who knew that it was in pixels.
What specific areas of your project would you like help with?I still don't quite understand how I should use the spacing section of the Figma design system where it has spaces listed in 100, 200, 300, and so on. I have been measuring the spaces with the move tool in the design.
I am also confused about the text presets. It seems like they do not quite line up with the bold and regular on the design itself. It isn't a big deal because it is listed in the typography on the particular element. Perhaps this is how it would be on a larger project? I also had to do some guesswork to get the exact font weights correct. I do not know if this is standardized or listed somewhere I didn't see.
- @wolverwinSubmitted about 2 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud of my SASS usage and the usage of nesting.
Next time I want to start mobile first.
What specific areas of your project would you like help with?I'm open to any kind of feedback from HTML to SASS.
@Gbw699Posted about 2 months ago@wolverwin Very nice work!!
I found in your repo this article about how to make CSS responsive without media queries and it was very interesting and usefull.
1 - @FilostkanaSubmitted about 2 months agoWhat are you most proud of, and what would you do differently next time?
-
I'm so proud that I've finishing the hall project, and I did that by my own, and I've learning and introduced to new technologies such as Sass and Figma
-
I'll spend much more time in planing and refined the components and the structure of the project before writing any code.
I was lost at the beginning and don't know where I shod start.
so I start writing a massif code.
but I gathering my self and focus. I do It eventually.
What specific areas of your project would you like help with?I would like some help with the start code on the CSS file what the default setting.
-
