Eric Agard• 60
@EAgard-34
Submitted
Looking forward to feedback, want to get better much thanks
Gaston
@GastonSKL
All comments
- Gaston• 170
@GastonSKL
Posted
Hi! Very nice work and a great end result! A feedback that I can give you is that in order to center your main container, is to place it inside another one, give it a heigth of 100vh, a display grid and a propertie of place content : center. This will place the container that you are working with in the center of the screen. Keep up the great job and congratulations!
0 - Muhammad Shoaib• 70
@melsayedshoaib
Submitted
Gaston• 170@GastonSKL
Posted
Great work and very good solution! I liked the way your code is organized! One sugestion that I can give you is that you can place the footer outside your main component, place the container in a larger one that has 100vh in height so it ocuppies the entirety of the visible screen, give this one a grid display, and a place content center propertie so it align the main container in the center of the screen! You can also use var() for the colors in a :root pseudoclass in your stylesheet so it becomes more accesible if you want to make changes in your color palette. Keep up your nice work! :)
Marked as helpful
1
