@chusu91Submitted over 2 years ago
Hello! This is my first challenge for FrontEndMentor!
Can someone give me Feedback? lots of thanks in advance !
Ganesh
@Ganesh-RathorAll comments
- @Ganesh-RathorPosted over 2 years ago
@Lucky Hey, great work bro 99 level perfection
Marked as helpful0 - @KrishangSharmaSubmitted over 2 years ago@Ganesh-RathorPosted over 2 years ago
In your code that I found bad for any code
- you use too much of div tag instead you can use html seamestic tag
- Instead of using hsl(); color in your css style you need to use variable of css It is grae then using hsl 3 . great logic on js dom
0 - @Ganesh-RathorSubmitted almost 3 years ago
this is my best clear work with flex and positioning But one thing that sour in my eyes is the default margin between two element I do margin: 0; of body container and container item but this margin wasn't remove
plese Give me feedback on 1.how I Null the default margin 2. how I do the page responsive for mobile I do it @media (max-width: 400px) .container{ flex-direction: coloum;} but it doesn't working
@Ganesh-RathorPosted almost 3 years agothanks to all for there knowledgeable feedback on my project. But I have one question on frontend review on my live site https://ganesh-rathor.github.io/challange-coloum-component/ the 3-coloumn-component-image was looking nicer and there is no less margin-bottom of button . But in the frontend review page it show much more margin on bottom of batton how it is happened
0 - @Ganesh-RathorSubmitted almost 3 years ago
using font is little bit difficult and what is the color of heading font
@Ganesh-RathorPosted almost 3 years agoI apologize for not seeing the font . by the way Thanks bro for your review
0
