Skip to content
OverviewSolutions
4
Comments
3
Flavio S.V
@Flavio-sv

All comments

  • Flavio S.V•60
    @Flavio-svPosted 4 months ago

    Your HTML and CSS code for the recipe page is well-structured and follows good web development practices. Here’s some feedback to help you refine your project further:

    HTML

    What’s Good:

    • Clear and organized structure with semantic elements.
    • Good use of classes and IDs for styling and layout.

    Suggestions:

    • Add comments to describe sections and any specific logic.
    • Consider using more specific class names (e.g., hero-image instead of hero_image).

    CSS

    What’s Good:

    • Effective use of CSS variables for color management.
    • Well-organized @font-face declarations and media queries for responsiveness.

    Suggestions:

    • Group @font-face rules for better readability.
    • Remove redundant properties (e.g., background-color in .hero_image).
    • Ensure consistent units for properties and avoid excessive specificity.

    Overall, you’ve done a great job with the project! These small tweaks will make your code even more robust and maintainable. Keep up the excellent work!

    0
  • Flavio S.V•60
    @Flavio-svPosted 6 months ago

    Your code is quite well-structured, but I would suggest making your HTML cleaner by removing those <div> tags and using a semantic tag called <nav> along with a <ul> to organize the <a> links, thereby tidying up the code. Below is an example:

    <nav>
    <ul>
        <li><a href="https://github.com/">GitHub</a></li>
        <li><a href="https://www.frontendmentor.io/">Frontend Mentor</a></li>
        <li><a href="https://www.linkedin.com/">LinkedIn</a></li>
        <li><a href="https://twitter.com/">Twitter</a></li>
        <li><a href="https://www.instagram.com/">Instagram</a></li>
    </ul>
</nav>

    Regarding your CSS code, I would suggest using clamp() to make it more responsive.

    Marked as helpful
    1
  • Flavio S.V•60
    @Flavio-svPosted 6 months ago

    Congratulations, your project is well-structured; you just need to focus a bit more on the details to make it as close as possible to the original.

    0