"Feedback welcome!"
Finney
@Finney06All comments
- @yozidstSubmitted 11 months ago
- @MelvinAguilarSubmitted 11 months ago
Hi there π, Iβm Melvin, and this is my solution for this challenge. π
π Features:
- Achieved 100% in Lighthouse score for performance, accessibility, best practices, and SEO. π
- Progressive Web App (PWA) support. π±π
- Utilized TailwindCSS for responsive styling. π¨
- Codebase is well-maintained and formatted using Prettier. π»
- Resemblance with the original design. π¨
- No media queries were used. π±
- Integrated very small animation. β¨
π» Two Solutions in Two Branches:
- Native HTML Solution: Utilizing
<details>
and<summary>
tags without the need for JavaScript. π - Accessible Disclosure Solution: Implementing Accessible Disclosure with a11y in mind for enhanced accessibility. π
π οΈ Built With:
- TailwindCSS. π¨
- npm - prettier - prettier-plugin-tailwindcss. π»
-
π Further Resources:
If you're interested in creating an Accessible Disclosure, I recommend checking out this informative article by Grace Snow: Tutorial: Let's Build an Accessible Disclosure
Any suggestions on how I can enhance this solution or achieve even better performance are welcome!
Thank you. πβοΈ
@Finney06Posted 11 months agoIsn't the button meant to close when another button is been click...?
1 - @musanurbadrSubmitted over 1 year ago@Finney06Posted over 1 year ago
Hello Musa π. Good job on completing the challenge !
Here are some suggestions regarding your code that may be of interest to you.
HTML π·οΈ:
To clear the Accessibility report:
The error message "
ul
andol
must only directly containli
,script
, or template elements" typically appears when there is invalid HTML markup in the code. This error indicates that either an<ul>
or<ol>
element contains an element other than<li>
,<template>
elements as direct children.-
If you need to include other types of elements within a list, you can nest them within an
<li>
element. -
Use a validator tool to check your HTML code for other possible errors.
Here's an example of valid HTML markup for an ordered list:
<ol> <li>Item 1</li> <li>Item 2</li> <li>Item 3</li> </ol>
And here's an example of valid HTML markup for an unordered list:
<ul> <li>Item 1</li> <li>Item 2</li> <li>Item 3</li> </ul>
By ensuring that your HTML markup follows the specifications, you can avoid errors and ensure that your web page is accessible to all users.
- The error message "All page content should be contained by landmarks" typically appears when the HTML code does not contain the necessary accessibility landmarks to help users navigate the content of the page. In this case, the
<div>
element with class "attribution" is not a landmark or a footer element, and therefore it does not provide any navigation aid for users.
To fix this error, you can do the following:
-
Use HTML5 landmarks: HTML5 introduced several new elements that can be used to define the different sections of a web page, such as
<header>
,<nav>
,<main>
,<aside>
, and<footer>
. By using these elements, you can create a clear hierarchy of content that is easy to navigate for users. -
Include a footer element: A footer element should be included at the end of the document and contain information about the website or document, such as copyright information or contact details.
Here is a [**web accessibility evaluation tool**](https://wave.webaim.org/)π to check your webpage for any remaining errors or warnings related to landmarks. I hope you find it helpful!π Above all, the solution you submitted is π. πHappy coding!
Marked as helpful0 -
- @aratinauSubmitted over 1 year ago
I'm happy with the way I made my triangle. I used
::after
on the bubble..space-left-bubble::after { content: " "; position: absolute; bottom: 0; right: 0; height: 15px; width: 15px; /* triangle part */ --size-triangle: 20px; border-top: var(--size-triangle) solid white; border-left: var(--size-triangle) solid transparent; transform: translateY(var(--size-triangle)); }
@Finney06Posted over 1 year agoHello Aymeric π. Good job on completing the challenge !
Here are some suggestions regarding your code that may be of interest to you.
HTML π·οΈ:
To clear the Accessibility report:
-
Images should have alternate text.
<img class="img-bubble" src="images/icon-upload.svg" alt="upload icon">
this provides alternative text descriptions of images for people who are visually impaired and rely on screen readers to navigate the web. Screen readers can read the alt text aloud, enabling these users to understand what the image represents and how it relates to the content on the page. Overall, including alt text in HTML is an important best practice for creating accessible and user-friendly web content. -
Wrap the page's whole main content in the
<main>
tag. -
Always avoid skipping heading levels; Starting with
<h1>
and working your way down the heading levels (<h2>
,<h3>
, etc.) helps ensure that your document has a clear and consistent hierarchy. -
Use HTML5 semantic elements such as
<header>
,<nav>
,<main>
,<aside>
, and<footer>
to define these sections.
I hope you find it helpful!π Above all, the solution you submitted is π. πHappy coding!
Marked as helpful0 -
- @mnacfilSubmitted over 1 year ago@Finney06Posted over 1 year ago
Hello Melvinπ. Good job on completing the challenge !
Here is a suggestion regarding your code that may be of interest to you.
HTML π·οΈ:
To clear the Accessibility report:
- Always avoid skipping heading levels; Starting with
<h1>
and working your way down the heading levels (<h2>
,<h3>
, etc.) helps ensure that your document has a clear and consistent hierarchy.
I hope you find it helpful!π Above all, the solution you submitted is π. πHappy coding!
0 - Always avoid skipping heading levels; Starting with
- @Jalal-AljhnySubmitted over 1 year ago@Finney06Posted over 1 year ago
Hello Jalal-Aljhny π. Good job on completing the challenge !
Here is a suggestion regarding your code that may be of interest to you.
HTML π·οΈ:
To clear the Accessibility report:
- Always avoid skipping heading levels; Starting with
<h1>
and working your way down the heading levels (<h2>
,<h3>
, etc.) helps ensure that your document has a clear and consistent hierarchy.
I hope you find it helpful!π Above all, the solution you submitted is π. πHappy coding!
Marked as helpful0 - Always avoid skipping heading levels; Starting with
- @Omart4Submitted over 1 year ago@Finney06Posted over 1 year ago
Hello Omarπ. Good job on completing the challenge !
Here are some suggestions regarding your code that may be of interest to you.
HTML π·οΈ:
To clear the Accessibility report:
-
Wrap the page's whole main content in the
<main>
tag. -
Use HTML5 semantic elements such as
<header>
,<nav>
,<main>
,<aside>
, and<footer>
to define these sections. -
Use ARIA landmarks such as
<header role="banner">
and<footer role="contentinfo">
to provide additional information about the purpose of each section to assistive technologies.
Here is a web accessibility evaluation toolπ to check your webpage for any remaining errors or warnings related to landmarks.
I hope you find it helpful!π Above all, the solution you submitted is π. πHappy coding!
0 -
- @AKSTHIRUMURUGANSubmitted over 1 year ago@Finney06Posted over 1 year ago
Hello there π. Good job on completing the challenge !
Here are some suggestions regarding your code that may be of interest to you.
HTML π·οΈ:
To clear the Accessibility report:
-
Wrap the page's whole main content in the
<main>
tag. -
Always avoid skipping heading levels; Starting with
<h1>
and working your way down the heading levels (<h2>
,<h3>
, etc.) helps ensure that your document has a clear and consistent hierarchy. -
Use HTML5 semantic elements such as
<header>
,<nav>
,<main>
,<aside>
, and<footer>
to define these sections. -
Use ARIA landmarks such as
<header role="banner">
and<footer role="contentinfo">
to provide additional information about the purpose of each section to assistive technologies.
Here is a web accessibility evaluation toolπ to check your webpage for any remaining errors or warnings related to landmarks.
I hope you find it helpful!π Above all, the solution you submitted is π. πHappy coding!
0 -
- @Yogesh-KumarrSubmitted over 1 year ago@Finney06Posted over 1 year ago
Hello Yogesh-Kumarr π. Good job on completing the challenge !
Here are some suggestions regarding your code that may be of interest to you.
HTML π·οΈ:
To clear the Accessibility report:
-
Wrap the page's whole main content in the
<main>
tag. -
Use HTML5 semantic elements such as
<header>
,<nav>
,<main>
,<aside>
, and<footer>
to define these sections. -
Use ARIA landmarks such as
<header role="banner">
and<footer role="contentinfo">
to provide additional information about the purpose of each section to assistive technologies.
Here is a web accessibility evaluation toolπ to check your webpage for any remaining errors or warnings related to landmarks.
I hope you find it helpful!π Above all, the solution you submitted is π. πHappy coding!
0 -
- @webgeek2021Submitted over 1 year ago
This project was quite challenging for me because it involved three different breakpoints. However, through this project, I learned a lot about responsiveness and how to approach Figma designs. Additionally, I had the opportunity to use Three.js SphereGeometry on the destination page, which was a new and exciting experience.
While building the project, I found it difficult to make the font size responsive. Despite using the clamp function, I was not satisfied with the output. Furthermore, I was unable to implement how to change the background image based on pages and device width. I would greatly appreciate any guidance on these issues.
As this was my first time implementing Three.js, I may encounter issues related to the size of geometry. Therefore, I am unsure about certain areas of my code.
@Finney06Posted over 1 year agoHello there π. Good job on completing the challenge !
Here are some suggestions regarding your code that may be of interest to you.
HTML π·οΈ:
To clear the Accessibility report:
-
Wrap the page's whole main content in the
<main>
tag. -
Use HTML5 semantic elements such as
<header>
,<nav>
,<main>
,<aside>
, and<footer>
to define these sections.
I hope you find it helpful!π Above all, the solution you submitted is π. πHappy coding!
0 -
- @yamenmaaniSubmitted over 1 year ago
tried to finish this page in 1:30 hours
@Finney06Posted over 1 year agoHello there π. Good job on completing the challenge !
Here are some suggestions regarding your code that may be of interest to you.
HTML π·οΈ:
To clear the Accessibility report:
-
Wrap the page's whole main content in the
<main>
tag. -
Use HTML5 semantic elements such as
<header>
,<nav>
,<main>
,<aside>
, and<footer>
to define these sections.
I hope you find it helpful!π Above all, the solution you submitted is π. πHappy coding!
0 -
- @stzivelSubmitted over 1 year ago@Finney06Posted over 1 year ago
Hello there π. Good job on completing the challenge !
Here are some suggestions regarding your code that may be of interest to you.
HTML π·οΈ:
To clear the Accessibility report:
-
Images should have alternate text.
-
Wrap the page's whole main content in the
<main>
tag. -
Use HTML5 semantic elements such as
<header>
,<nav>
,<main>
,<aside>
, and<footer>
to define these sections. -
Use ARIA landmarks such as
<header role="banner">
and<footer role="contentinfo">
to provide additional information about the purpose of each section to assistive technologies.
Here is a web accessibility evaluation toolπ to check your webpage for any remaining errors or warnings related to landmarks.
I hope you find it helpful!π Above all, the solution you submitted is π. πHappy coding!
0 -