All comments

• 

  Mykola Pyroh•30

  @mykola-pyrohSubmitted 5 days ago

  

  Blog preview card (Using HTML, SCSS and BEM)

  1

  30
  

  P

  Ferdiansyahmulyadi•20

  @FerdiansyahmulyadiPosted 3 days ago

  Hi @mykola-pyroh,

  This looks good, the blog preview card looks the same as the design. I think we can improve it in some ways:

  1. Make a container to wrap the blog preview card
  2. Code the container with max-width and max-height to match the width and height of the preview card.
  3. Set the margin of the container, so that the top, bottom, left, and right stay center.

  Here is my .container code, by the way, I use SCSS to complete this challenge: .container { max-width: rem-calc(384); max-height: rem-calc(522); padding: 0 0; margin: rem-calc(219) auto; }

  Good luck!

  0
• 

  Katte18•50

  @Katte18Submitted almost 2 years ago

  May I ask for code improvement via refactoring. Thank you

  

  HTML, CSS, JS, API

  1

  150
  

  P

  Ferdiansyahmulyadi•20

  @FerdiansyahmulyadiPosted 4 days ago

  It looks good, but I think you can set the background color from the body tag, create a main container, and set the margins top and bottom with the same value, left-right auto. Good luck!

  0