Skip to content
OverviewSolutions
13
Comments
10
Luis Felipe
@FelipinDR

All comments

  • Luis Felipe•230
    @FelipinDRPosted almost 2 years ago

    You should not use an alt tag in the icons because they're just icons and you should also add a "aria-hidden:true" to hide from accessibility Parabens por ter concluido esse desafio, good luck with the next

    1
  • Luis Felipe•230
    @FelipinDRPosted almost 2 years ago

    Your icons should not have an alt tag because they're icons, also they should have a tag called "aria-hidden:true" to hide them from accessibility

    0
  • Luis Felipe•230
    @FelipinDRPosted almost 2 years ago

    Great job on doing this Your icons should not have an alt tag because they're just icons, also you should use "aria-hidden:true" to hide them from accessibility

    1
  • Luis Felipe•230
    @FelipinDRPosted almost 2 years ago

    You should not add an alt tag to the icons because they're just icons, also you should use "aria-hidden:true" to hide them from accessibility Good job finishing this, good luck with the next challenges

    Marked as helpful
    1
  • Luis Felipe•230
    @FelipinDRPosted almost 2 years ago

    Try using grid or flexbox than using position relative/absolute to center things

    Marked as helpful
    1
  • Luis Felipe•230
    @FelipinDRPosted almost 2 years ago

    You don't have to add an alt tag to the images because they're icons, you could use "aria-hidden:true" to accessibility too Nice job doing this, keep going <3

    Marked as helpful
    1
  • i_d_s_l•270
    @ilvdrsknSubmitted almost 2 years ago

    The layout itself is simple. I used flex properties to center the card, and for the exact location of the elements.

    used flexbox to manage elements

    2
    Luis Felipe•230
    @FelipinDRPosted almost 2 years ago

    Try using a responsive unit such as rem or em for the main container to add responsiveness to your site

    Marked as helpful
    1
  • Luis Felipe•230
    @FelipinDRPosted almost 2 years ago

    You can get the button color right by using "background-color:green" you can also put the cart image before in the cart using "background-image" to the text and then "background-repeat:no-repeat", padding-left:30px and display:block nice job doing this exercise mate, good luck with the next

    Marked as helpful
    0
  • Arthur Vieira•10
    @ArthurKanzakiSubmitted almost 2 years ago

    Tive algumas dificuldades na parte de estilização. Preciso entender mais na estilização do container e importação das novas fontes do site. Tentei focar mais na responsividade do site para que seja compatível no desktop e mobile, sem utilizar as medias query.

    Página responsiva utilizando Dipslay Flex

    1
    Luis Felipe•230
    @FelipinDRPosted almost 2 years ago

    Você poderia colocar a imagem svg usando uma tag de img, fica melhor para ler no codigo outra dica é usar "aria-hidden:true" nas imagens pois são apenas icones, para elas não serem lidas por ferramentas de acessibilidade tags h1 são feitas para serem usadas uma vez, poderia usar 3 h2 no lugar de 3 h1 também Nice job doing this code challenge, hope i'm helpful

    1
  • Luis Felipe•230
    @FelipinDRPosted almost 2 years ago

    Forgot the hover effect, gonna work on that soon

    0