Felipe J. Santos
@FelipeJSantos-ProgrammerAll comments
- @RubyJerlinaSubmitted 12 months ago@FelipeJSantos-ProgrammerPosted about 1 month ago
1.Your HTML solution has no semantics. It is not mandatory, but it makes the code less repetitive.
2.Your HTML project is accessible, but you need to point out in '<head>' the all the CSS links in order. reset, style and responsive. Using the QR Code and the text as images exported from figma, makes your work easier and helps save time as it is a static project.
3.Its layout seems to work well on mobiles, but not on desktop screens. Check the classes in the CSS Style and adjust their alignments of background 01, background 02 and qr-code + text (if you use as an image) independently.
4.[You can check my code to help with your adjustments] (https://github.com/FelipeJSantos-Programmer/qr-code-component).
5.The solution does not differ from the design, but it only needs these adjustments already mentioned that can help.
0