Skip to content
OverviewSolutions
11
Comments
3
Fatima
@FatimahFarooq

All comments

  • Fatima•145
    @FatimahFarooqPosted about 3 years ago

    I really appreciate your detailed feedback.I cannot thank you enough.What you've mentioned earlier regarding the 1440 px not being a breakpoint rather it's the layout size,I would like you to explain this a bit,if it's no trouble. Regarding what you mentioned about setting box-sizing:border-box,you are right,I need to find out more about this as I'm seeing it being used in all tutorials. Using proper html tags and adding an alt are such basics,I can't belive to have missed those..lol,will pay more attention.
    l'll be mindful of the height and width property as well,what you pointed out was great. The error-message attribute (aria-*) is new to me, I'll definetely read more about it. I'll check out the link you've shared too.Thank you so much,your feedback really gave me a lot to check out and learn.Thanks again.

    0
  • Fatima•145
    @FatimahFarooqPosted over 3 years ago

    Good job. You could also add/remove a (show/hide) class on the author div as well when share icon is clicked.

    0
  • Fatima•145
    @FatimahFarooqPosted over 3 years ago

    I really liked the animation that happens whenever a faq is hovered upon.Great Job!

    Marked as helpful
    0