Skip to content
OverviewSolutions
19
Comments
6
P
FRYDPHROG
@FRYDPHROG

All comments

  • FRYDPHROG•230
    @FRYDPHROGPosted 5 months ago

    Many of your classes can be merged into one class because they use the same styles, making it easier to read as well as getting rid of the necessity to constantly rewrite the same styles.

    For instance, all the images can share the same class because they are positioned in the same area of the card.

    0
  • JJ-codes-9•90
    @JJ-codes-9Submitted 9 months ago
    What are you most proud of, and what would you do differently next time?

    It's getting easier to work with CSS and I have more understanding of a responsive page.

    What challenges did you encounter, and how did you overcome them?

    My biggest challenge was to set the mobile and desktop views and I couldn't do them. Also when I shrink the browser the flexbox shrinks and the texts overflows. I couldn't find a way to make it look image on top and texts at the bottom for the mobile view.

    What specific areas of your project would you like help with?

    My biggest challenge was to set the mobile and desktop views and I couldn't do them.

    Also, when I shrink the browser, the flexbox shrinks, but the .right-column class overflows.

    I couldn't find a way to make the mobile look: image on top and texts at the bottom for the mobile view.

    Product Preview Card Component Challenge

    1
    FRYDPHROG•230
    @FRYDPHROGPosted 5 months ago

    If you set the flex-direction of your .product-box to column, you can position the image on top and the text at the bottom.

    0
  • FRYDPHROG•230
    @FRYDPHROGPosted 5 months ago

    Overall excellent; the only things that bother me are the h1 element font weight and the space between the text and subheaders.

    0
  • FRYDPHROG•230
    @FRYDPHROGPosted 5 months ago

    The size of the card itself is where I see the biggest difference. Additionally, I found that when you hover or click on the buttons, their colors do not change.

    You can achieve this by doing

    button:hover{ Background-color: ### }

    or with

    button:active{ Background-color: ### }

    Marked as helpful
    0
  • FRYDPHROG•230
    @FRYDPHROGPosted 5 months ago

    The only difference I notice is in the size, but apart from that, everything is flawless.

    1
  • SyedAliHamzaaa•10
    @SyedAliHamzaaaSubmitted 6 months ago
    What are you most proud of, and what would you do differently next time?

    Learning about git and github

    What challenges did you encounter, and how did you overcome them?

    it was simple no challenge at all

    What specific areas of your project would you like help with?

    All Feedback is welcomed, Thank-You

    QR Code Component

    2
    FRYDPHROG•230
    @FRYDPHROGPosted 5 months ago

    Greetings SyedAliHamzaaa, Your HTML structure is flawless. However, I noticed that the card appears to be slightly undersized and not aligned centrally. I recommend checking the width of your ".qr-code" component again.

    0