Skip to content
OverviewSolutions
3
Comments
5
Vinny_A
@Eye0001

All comments

  • mohammedreddah•50
    @mohammedreddahSubmitted 4 months ago
    What specific areas of your project would you like help with?

    Hello everyone !!

    Thankfully i didn't face a serious issue Durring the completion of the project .

    But the way i specified the font family is kinda unprofessional, because the style-guide file already gave me an url of a font family but for a reason it doesn't apply.... so i forced a similar font using the font-family property. If anyone can help with this small issue i'll be grateful : ) .

    QR code Component

    1
    Vinny_A•50
    @Eye0001Posted 4 months ago

    Hello @mohammedreddah

    Congrats on completing the challenge. You did a great job.

    For your concerns regarding the font, there are two main ways I would do it:

    1. Link/import: The first method involves going to fonts.google.com and searching for the font that fits your needs. You can then click the Get Font button in the upper right corner and then the Get embed code button. Make sure you have selected the Web option, you can then choose what font weight you want. You can either choose to use a link tag in your HTML or @import in your CSS.

    2. The second method involves you downloading the font directly to your project. Once you have done this you can use @font-face in your CSS file to use the font. The second part of this video explains it well.

    0
  • melissa-koi•10
    @melissa-koiSubmitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    Completed my first challenge on this platform!

    What challenges did you encounter, and how did you overcome them?

    I didn't face any major challenges

    What specific areas of your project would you like help with?

    Any feedback on my code and design will be highly appreciated

    QR code challenge

    1
    Vinny_A•50
    @Eye0001Posted 4 months ago

    Hello @melissa-koi

    Congratulations on completing your first challenge! That's a tremendous accomplishment. I have some feedback for you that I hope you will find helpful:

    • Include a CSS reset: A reset will remove all default stylings as not all browsers have the same stylings. Use this for a more consistent starting point. Here is a good source that will help you get started.
    • Don't use pixels for font size: Pixels won't scale for users who have poor eyesight and change their default font size. Instead, use rems, which offer better accessibility.
    0
  • Vinny_A•50
    @Eye0001Posted 4 months ago

    Hello @DKVyotu

    Good job on completing the challenge, you did very well. I noticed something in your code that could be improved.

    Don't use px for sizing font, it won't scale for users that have chosen their font size, use units like rem instead. Read more here.

    0
  • Vinny_A•50
    @Eye0001Posted 4 months ago

    Hello @3laagaber

    Great job on completing the blog preview card. It matches the original design very well. However, it seems you didn't include the active states.

    You can see what active states you need to add by going into design/active-states.jpg. You can read more on the selector needed here.

    Marked as helpful
    0
  • Vinny_A•50
    @Eye0001Posted 4 months ago

    Looks great! It's very close to the original.

    I like how the code is structured and that it works on all screen sizes. I can't find anything for you to improve upon besides changing the .text padding so the text is level.

    Good job.

    0