Skip to content
OverviewSolutions
2
Comments
3
James Atkins
@End-Us3r

All comments

  • James Atkins•40
    @End-Us3rPosted 4 months ago

    That's pretty cool! Awesome work! The only thing I would say is that the link hanging out at the bottom is in the way, IMO it would look better without it being there. Also, I'm able to scroll down on the page which kinda takes away from the experience. Great work though.

    0
  • James Atkins•40
    @End-Us3rPosted 4 months ago

    Looks great, good job! Don't forget about the border line on the outside of the card, unless you've chosen to ignore it.

    0
  • kapowlo•80
    @kapowloSubmitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    I'm not sure if giving html,body a height of 100% was better than simply setting body to a 100vh. Since i want my container to take up the full page.

    What challenges did you encounter, and how did you overcome them?

    I originally had a repository on GitHub called frontend-mentor-challenges, where I was gonna put all my Frontend mentor projects.But after looking a bit online this wasn't recommended.So i'll just stick to one repository per project which ,as a beginner, makes it easier to deploy with GitHub pages.

    html and CSS(flexbox) Qr Code Component

    1
    James Atkins•40
    @End-Us3rPosted 4 months ago

    Hey @kapowla, I just got started on this platform so they have me reviewing your code. Anyway, a couple of quick fixes will have you closer to what they want. I would decrease the width of the elements a bit, adjust your border radius for the corners, and make the spacing on the left/right and top of the image element equal to each other. Hope this helps, Good luck!

    Marked as helpful
    0