Elyor05

Latest comments

• 

  Kingselo•70

  @KingseloSubmitted about 2 months ago

  

  Created a tip caculator using html, javascript and css

  #pure-css

  1

  10
  

  Elyor05•200

  @Elyor05Posted about 1 month ago

  Great job, but:

  • your header's word "splitter" in tablet version looks odd, as i saw you forgot adding line-height to media (min-width: 700px) and (max-width: 1000px)
  • in images we had logo.svg that we can use instead of making it, i also didn't notice it at start so, i made header also by myself, you can check if you want.

  Firstly you can add line-height to media queries, to see how it should look, then replace it with logo.svg

  0
• 

  Omega•70

  @gracomeSubmitted about 1 month ago

  

  Recipe page

  1

  20
  

  Elyor05•200

  @Elyor05Posted about 1 month ago

  Great job, but:

  • The only things that can be fixed is tablet view of your website.I see you used media queries, but set

  .main {
           padding: 0; 
           margin: 0; 
           display: block;
  }
  

  which made it looks odd.

  Marked as helpful

  0
• 

  Dimitar Radulov•90

  @dimitarradulovSubmitted almost 3 years ago

  

  Responsive desktop-first solution using CSS Grid and Flexbox

  #bem#fetch

  1

  30
  

  Elyor05•200

  @Elyor05Posted about 1 month ago

  Grate job.

  • to get rid of colors of the edges just set border-radius of <div class="card card--${title}"> larger that <div class="card__content">…</div>. Set for 2rem, for example.

  On the other hand, everything is perfect.

  0
• 

  Ahmed Ibrahem•40

  @Ahmed-dark7Submitted about 1 month ago

  

  qr-code-component-main

  1

  20
  

  Elyor05•200

  @Elyor05Posted about 1 month ago

  Great job, but:

  • You should probably work on adaptive design.
  • Firstly, you can use 'vh' - viewheight and 'vw' - viewwidth when setting height and width for your element, it will resize based on screen resolution
  • Secondly(i suggest this one), you can use media queries, they allow you write css styles for certian devices

  // setting css styles for tablets 
  @media screen and (max-width: 769px){
  body {
      display: flex;
  }
  }
  

  i hope you will keep working

  Marked as helpful

  0
• 

  Joseph Stalin•240

  @Soliman0100Submitted about 1 month ago

  

  nothing new

  1

  10
  

  Elyor05•200

  @Elyor05Posted about 1 month ago

  Good job, everything looks good, but...

  • Your images arent loading up, select correct path to your image
  • Also sort your files in folder in your github, ut will be easier to understand which file is where, for you and for other people

  0
• 

  RoelofWobben•20

  @RoelofWobbenSubmitted about 1 month ago

  What are you most proud of, and what would you do differently next time?

  I would different that some things are gone in my mind. So I would take a beginners course in css to get into it.

  What challenges did you encounter, and how did you overcome them?

  no real challenges

  What specific areas of your project would you like help with?

  is this site good responsive ? Did I use semantic html well ? Are there other things I could improve ?

  

  Responsive blog card

  2

  10
  

  Elyor05•200

  @Elyor05Posted about 1 month ago

  Great job.

  • You set background-color for the main tag, i suggest you to set it on body tag. Your page will be looking good and without whitespaces around

  body {
      background-color: var(--yellow)
  }
  

  • You have a great responsive design and without using media queries

  0