@siddhivitadhekaleSubmitted about 2 months ago
ElkuchWaltz
@ElkuchWaltzAll comments
- @yasminegamal19Submitted 3 months ago@ElkuchWaltzPosted 3 months ago
Excellent work! The design looks nearly identical and the code looks clearly and effectively written to my newbie eyes!
The only points I notice where it could be improved are small details:
- PERFUME should be in all caps
- The font weight on 149.99 is too low
- The button doesn't change colors during hover
I think the resolving those would make this solution perfect! Keep up the great work!
0 - @Born2FlexSubmitted 3 months ago@ElkuchWaltzPosted 3 months ago
Excellent work! The layout looks nearly identical, nice job!
The only thing that I notice is that the font didn't change to Young Serif for the h1 and h2 as you've written it to. I see that you pulled the font with the @ at the top of the CSS file, but I've found that I have more luck pulling Google fonts in the header of the HTML file. You may want to try that and see if the font works then. I'd also suggest adding ", serif" after "Young Serif" in the stylesheet so that it defaults to another serif font when Young Serif is not available.
Overall, looking great! Keep it up!
Marked as helpful0 - @MarioomarioSubmitted 4 months ago
- @Adnan7389Submitted 3 months agoWhat specific areas of your project would you like help with?
- Layout
- font weight and size
- line-height and letter-spacing properties
- color
@ElkuchWaltzPosted 3 months agoExcellent work! I just completed this project too, and it looks like you were able to match the original much more closely than I was, well done!
One piece of advice I received on mine was to use rem instead of px for font size. I know the Frontend mentor style sheet gives us the <p> font-size in px, but rem can scale better for users who want to change the font size in their screens.
0 - @Sushant203Submitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I am proud of myself that I actually attempted this challenge and genuinely completed it without much help and assistance. I will definitely try to improve my code using more specific HTML5 semantics.
What challenges did you encounter, and how did you overcome them?I was getting problem in centering the div properly and MDN DOCS CSS flexbox property article helped me to overcome that problem and complete my challenge .
What specific areas of your project would you like help with?I'd appreciate if i got helped in writing more clear css codes and usage of flexbox property more specifically.
