Yeabsera• 70
@Yab1
Submitted
Elijah-05
@Elijah-05
All comments
- Elijah-05• 30
@Elijah-05
Posted
Hey! Congra for finishing this challenge.
- I think it is better if you use the QR Image nest inside the div element, like this
<div> <img src=" " alt="" /> </div>. Because it is Image, not just for decoration purpose. screen readers should read the image by thealt=""attribute. and also you don't need more styling for this case. - The other is recommended to always start by semantic elements, that means
<main> </main><header> </header>and others. nest all ur codes inside <main> semantic element. that is why Accessibility report is issued.
0 - I think it is better if you use the QR Image nest inside the div element, like this
- Ibraheem• 10
@IbraheemSaburdheen
Submitted
Elijah-05• 30@Elijah-05
Posted
Congratulation for finishing the first challenge. You did really did it!
- There is uncommon usage of html image element attribute value
<img src="images\image-qr-code.png" alt="QR Image">change the back slash\to for slash/ - and also try to start the image path like
<img src="./images/image-qr-code.png" alt="QR Image">
0 - There is uncommon usage of html image element attribute value
- yahia5034• 10
@yahia5034
Submitted
The first difficulty was to take the width of the whole page. the second one was to insert the image inside the container and keep it in there.
Elijah-05• 30@Elijah-05
Posted
Congratulation to finish the challenge.
- The heading below the QR image that is
<h2>should be<h1>. In your code any Heading should start from<h1>even if it should be small. so you can adjust it then by its font size. - The other is the heading again is three line. so adjust it with its font size and
#card-contentside paddings - the heading <h2> also nest <p> element. No need to nest <p> inside <h2> element. put your heading content directly in <h1> element.
1 - The heading below the QR image that is
