All comments

• 

  Jaonary Andritiana•70

  @tix04Submitted about 3 years ago

  Hello, as usual please send me any remarks on anything that you think I can improve either for the layout or the code itself? Tell me if my solution is valid... I have one thing to note though, I had some trouble with the two white testimonial components. The padding for the desktop layout for both components do not seem to look exactly like the mockup I downloaded. The padding I used for all components are the same for both mobile and desktop layouts. I don't understand why when compared to the mockup, the two white components in my solution looks like it has more padding-bottom than the mockup. I am not sure if it s my eyes or am I being too perfectionist!! Can anyone propose a solution for this or would this small difference be accepted in real life work? Or am I just having an optic illusion and there is nothing wrong with it lol lol?? Again, thank you in advance for anyone taking the time to look at my solution and answering my questions!!

  

  HTML CSS3 SASS BEM

  1

  10
  

  Hassan Elabadi•150

  @Elab4d1Posted about 3 years ago

  Hey, awesome work on this one. Layout in general looks really good.

  • Use this on the body tag to center the content:

  body {
    align-items: center;  # centers vertically
    display: flex;
    justify-content: center;  # centers horizontally
    min-height: 100vh;  # takes full viewport
  }
  

  • Always have an h1 element on a webpage.
  • I noticed that the dimensions of the images aren't good so use px instead of rem, I don't know why but this should work.

  Aside from those, really great job on this one.

  0
• 

  juan ochoa•70

  @incanloveSubmitted about 3 years ago

  I would like to hear everyone's tip on how to make the website be more responsive when going into mobile mode

  

  Html/Css

  1

  10
  

  Hassan Elabadi•150

  @Elab4d1Posted about 3 years ago

  don't forget to add border-radius to the whole thing

  Marked as helpful

  0